diff --git a/self-development/kelos-pr-responder.yaml b/self-development/kelos-pr-responder.yaml index 197e7823..61376703 100644 --- a/self-development/kelos-pr-responder.yaml +++ b/self-development/kelos-pr-responder.yaml @@ -81,8 +81,8 @@ spec: - 2. Read ALL comments on the linked issue referenced by the PR body. First determine the linked issue number from the PR body, then run `gh issue view --comments`. If `KELOS_UPSTREAM_REPO` is set, use `--repo "$KELOS_UPSTREAM_REPO"`. - 3. Read the existing diff (git diff main...HEAD) to understand what has already been done. Do NOT start over or rewrite from scratch. - 4. Make only the incremental changes needed to address review feedback or remaining issues. Preserve existing work. - - 5. Commit and push your changes to origin {{.Branch}}. - - 6. /review the PR to verify your changes address the feedback. If changes are needed, make them, commit and push, then /review again. Repeat until the review passes. + - 5. Commit and push your changes to origin {{.Branch}} (use `--force-with-lease` if the push is rejected after rebasing). + - 6. Self-review your changes: run `git diff origin/main...HEAD` and read the full diff to verify correctness, check for unintended changes, and ensure the diff only contains changes relevant to the task. Fix any issues you find, then commit and push again. Do NOT post "/review" as a PR comment — it does not trigger anything. - 7. Update the PR title and description to reflect the final diff. The PR body MUST contain a standard closing keyword reference on its own line (e.g., `Fixes #123` or `Closes #123`). Do not embed the issue number in natural language. Ensure the PR has labels "generated-by-kelos" and "ok-to-test" (use `gh pr edit {{.Number}} --add-label generated-by-kelos --add-label ok-to-test` if missing). If `KELOS_UPSTREAM_REPO` is set, include `--repo "$KELOS_UPSTREAM_REPO"`. - 8. Make sure the PR passes all CI tests.