diff --git a/AGENTS.md b/AGENTS.md index 51eea5b..a953da8 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -22,7 +22,7 @@ - Fill in every section of the template. Do not remove or skip sections — use "N/A" or "NONE" where appropriate. - Choose exactly one `/kind` label from: `bug`, `cleanup`, `docs`, `feature`. - If there is no associated issue, write "N/A" under the issue section. -- If the PR does not introduce a user-facing change, write "NONE" in the `release-note` block. +- If the PR does not introduce a user-facing change, write "NONE" in the `release-note` block. If the PR introduces new API fields, user-facing features, or behavioral changes, describe them in the `release-note` block. ## Directory Structure - `cmd/` — CLI entrypoints diff --git a/self-development/kelos-pr-responder.yaml b/self-development/kelos-pr-responder.yaml index 197e782..27d947c 100644 --- a/self-development/kelos-pr-responder.yaml +++ b/self-development/kelos-pr-responder.yaml @@ -83,7 +83,7 @@ spec: - 4. Make only the incremental changes needed to address review feedback or remaining issues. Preserve existing work. - 5. Commit and push your changes to origin {{.Branch}}. - 6. /review the PR to verify your changes address the feedback. If changes are needed, make them, commit and push, then /review again. Repeat until the review passes. - - 7. Update the PR title and description to reflect the final diff. The PR body MUST contain a standard closing keyword reference on its own line (e.g., `Fixes #123` or `Closes #123`). Do not embed the issue number in natural language. Ensure the PR has labels "generated-by-kelos" and "ok-to-test" (use `gh pr edit {{.Number}} --add-label generated-by-kelos --add-label ok-to-test` if missing). If `KELOS_UPSTREAM_REPO` is set, include `--repo "$KELOS_UPSTREAM_REPO"`. + - 7. Update the PR title and description to reflect the final diff. The PR body MUST contain a standard closing keyword reference on its own line (e.g., `Fixes #123` or `Closes #123`). Do not embed the issue number in natural language. Ensure the PR has labels "generated-by-kelos" and "ok-to-test" (use `gh pr edit {{.Number}} --add-label generated-by-kelos --add-label ok-to-test` if missing). If `KELOS_UPSTREAM_REPO` is set, include `--repo "$KELOS_UPSTREAM_REPO"`. The PR body MUST include a `release-note` block: if the change introduces new API fields, user-facing features, or behavioral changes, describe them in the block; otherwise write "NONE". - 8. Make sure the PR passes all CI tests. Post-checklist: diff --git a/self-development/kelos-workers.yaml b/self-development/kelos-workers.yaml index 3ea9981..4310b8b 100644 --- a/self-development/kelos-workers.yaml +++ b/self-development/kelos-workers.yaml @@ -100,7 +100,7 @@ spec: - 4a. Make only the incremental changes needed to address review feedback or remaining issues. Preserve existing work. - 5a. Commit and push your changes to origin kelos-task-{{.Number}}. - 6a. /review the PR to verify your changes address the feedback. If changes are needed, make them, commit and push, then /review again. Repeat until the review passes. - - 7a. Update the PR title and description to reflect the final diff. The PR body MUST contain a standard closing keyword reference on its own line (e.g., `Fixes #{{.Number}}` or `Closes #{{.Number}}`). Do not embed the issue number in natural language. Ensure the PR has labels "generated-by-kelos" and "ok-to-test" (use `gh pr edit {{.Number}} --add-label generated-by-kelos --add-label ok-to-test` if missing). + - 7a. Update the PR title and description to reflect the final diff. The PR body MUST contain a standard closing keyword reference on its own line (e.g., `Fixes #{{.Number}}` or `Closes #{{.Number}}`). Do not embed the issue number in natural language. Ensure the PR has labels "generated-by-kelos" and "ok-to-test" (use `gh pr edit {{.Number}} --add-label generated-by-kelos --add-label ok-to-test` if missing). The PR body MUST include a `release-note` block: if the change introduces new API fields, user-facing features, or behavioral changes, describe them in the block; otherwise write "NONE". - 8a. Make sure the PR passes all CI tests. If no PR exists: @@ -112,7 +112,7 @@ spec: - 3b. Create a commit that fixes the issue. - 4b. Push your branch to origin kelos-task-{{.Number}}. - 5b. Create a PR with labels "generated-by-kelos" and "ok-to-test" (use `gh pr create --label generated-by-kelos --label ok-to-test`), then /review it. If changes are needed, make them, commit and push, then /review again. Repeat until the review passes. - - 6b. Update the PR title and description to reflect the final diff. The PR body MUST contain a standard closing keyword reference on its own line (e.g., `Fixes #{{.Number}}` or `Closes #{{.Number}}`). Do not embed the issue number in natural language. + - 6b. Update the PR title and description to reflect the final diff. The PR body MUST contain a standard closing keyword reference on its own line (e.g., `Fixes #{{.Number}}` or `Closes #{{.Number}}`). Do not embed the issue number in natural language. The PR body MUST include a `release-note` block: if the change introduces new API fields, user-facing features, or behavioral changes, describe them in the block; otherwise write "NONE". - 7b. Make sure the PR passes all CI tests. Post-checklist: