From efe2ed366ebdfecbda2631e986163e34567356bc Mon Sep 17 00:00:00 2001 From: Gunju Kim Date: Fri, 13 Mar 2026 13:57:22 +0000 Subject: [PATCH] Align triage agent kind/* labels with CLAUDE.md and sync agentsMD Replace kind/api with kind/cleanup in the triage agent prompt to match the canonical 4-label set defined in CLAUDE.md and the PR template. Update README.md to reflect the corrected label set. Add missing CLAUDE.md conventions to all 5 AgentConfig definitions: - Explicit "do not refactor" rule alongside "keep changes minimal" - CI/release workflow guidance - e2e test guidance - Directory Structure section - Test scope qualifier "(including integration, e2e)" Co-Authored-By: Claude Opus 4.6 --- self-development/README.md | 2 +- self-development/agentconfig.yaml | 11 +++++++++-- self-development/kelos-fake-strategist.yaml | 11 +++++++++-- self-development/kelos-fake-user.yaml | 11 +++++++++-- self-development/kelos-self-update.yaml | 11 +++++++++-- self-development/kelos-triage.yaml | 2 +- self-development/kelos-workers.yaml | 11 +++++++++-- 7 files changed, 47 insertions(+), 12 deletions(-) diff --git a/self-development/README.md b/self-development/README.md index c8c4fab4..7bc1b42f 100644 --- a/self-development/README.md +++ b/self-development/README.md @@ -122,7 +122,7 @@ Picks up open GitHub issues labeled `needs-actor` and performs automated triage. | **Concurrency** | 8 | **For each issue, the agent:** -1. Classifies with exactly one `kind/*` label (`kind/bug`, `kind/feature`, `kind/api`, `kind/docs`) +1. Classifies with exactly one `kind/*` label (`kind/bug`, `kind/feature`, `kind/cleanup`, `kind/docs`) 2. Checks if the issue has already been fixed by a merged PR or recent commit 3. Checks if the issue references outdated APIs, flags, or features 4. Detects duplicate issues diff --git a/self-development/agentconfig.yaml b/self-development/agentconfig.yaml index 499d945a..0fef3bae 100644 --- a/self-development/agentconfig.yaml +++ b/self-development/agentconfig.yaml @@ -17,7 +17,8 @@ spec: ## Standards - Do not create duplicate issues — check existing issues first with `gh issue list` - - Keep changes minimal and focused + - Keep changes minimal and focused. Do not refactor, reorganize, or 'improve' code beyond what was explicitly requested + - For CI/release workflows, always use existing Makefile targets rather than reimplementing build logic in YAML ## Project Conventions - Use Makefile targets instead of discovering build/test commands yourself: @@ -25,7 +26,13 @@ spec: - `make update` — update all generated files - `make test` — run all unit tests - `make test-integration` — run integration tests + - e2e tests are hard to run locally. Push changes and use the PR's CI jobs to run them instead - `make build` — build binary - - Always try to add or improve tests when modifying code + - Always try to add or improve tests (including integration, e2e) when modifying code - Logging conventions: start log messages with capital letters and do not end with punctuation - Commit messages: do not include PR links in commit messages + + ## Directory Structure + - `cmd/` — CLI entrypoints + - `test/e2e/` — end-to-end tests + - `.github/workflows/` — CI workflows diff --git a/self-development/kelos-fake-strategist.yaml b/self-development/kelos-fake-strategist.yaml index 875e2f38..8d158b3f 100644 --- a/self-development/kelos-fake-strategist.yaml +++ b/self-development/kelos-fake-strategist.yaml @@ -17,7 +17,8 @@ spec: ## Standards - Do not create duplicate issues — check existing issues first with `gh issue list` - - Keep changes minimal and focused + - Keep changes minimal and focused. Do not refactor, reorganize, or 'improve' code beyond what was explicitly requested + - For CI/release workflows, always use existing Makefile targets rather than reimplementing build logic in YAML ## Project Conventions - Use Makefile targets instead of discovering build/test commands yourself: @@ -25,10 +26,16 @@ spec: - `make update` — update all generated files - `make test` — run all unit tests - `make test-integration` — run integration tests + - e2e tests are hard to run locally. Push changes and use the PR's CI jobs to run them instead - `make build` — build binary - - Always try to add or improve tests when modifying code + - Always try to add or improve tests (including integration, e2e) when modifying code - Logging conventions: start log messages with capital letters and do not end with punctuation - Commit messages: do not include PR links in commit messages + + ## Directory Structure + - `cmd/` — CLI entrypoints + - `test/e2e/` — end-to-end tests + - `.github/workflows/` — CI workflows --- apiVersion: kelos.dev/v1alpha1 kind: TaskSpawner diff --git a/self-development/kelos-fake-user.yaml b/self-development/kelos-fake-user.yaml index 4e63a626..e97c7a90 100644 --- a/self-development/kelos-fake-user.yaml +++ b/self-development/kelos-fake-user.yaml @@ -17,7 +17,8 @@ spec: ## Standards - Do not create duplicate issues — check existing issues first with `gh issue list` - - Keep changes minimal and focused + - Keep changes minimal and focused. Do not refactor, reorganize, or 'improve' code beyond what was explicitly requested + - For CI/release workflows, always use existing Makefile targets rather than reimplementing build logic in YAML ## Project Conventions - Use Makefile targets instead of discovering build/test commands yourself: @@ -25,10 +26,16 @@ spec: - `make update` — update all generated files - `make test` — run all unit tests - `make test-integration` — run integration tests + - e2e tests are hard to run locally. Push changes and use the PR's CI jobs to run them instead - `make build` — build binary - - Always try to add or improve tests when modifying code + - Always try to add or improve tests (including integration, e2e) when modifying code - Logging conventions: start log messages with capital letters and do not end with punctuation - Commit messages: do not include PR links in commit messages + + ## Directory Structure + - `cmd/` — CLI entrypoints + - `test/e2e/` — end-to-end tests + - `.github/workflows/` — CI workflows --- apiVersion: kelos.dev/v1alpha1 kind: TaskSpawner diff --git a/self-development/kelos-self-update.yaml b/self-development/kelos-self-update.yaml index c5e4ea1c..add031f1 100644 --- a/self-development/kelos-self-update.yaml +++ b/self-development/kelos-self-update.yaml @@ -17,7 +17,8 @@ spec: ## Standards - Do not create duplicate issues — check existing issues first with `gh issue list` - - Keep changes minimal and focused + - Keep changes minimal and focused. Do not refactor, reorganize, or 'improve' code beyond what was explicitly requested + - For CI/release workflows, always use existing Makefile targets rather than reimplementing build logic in YAML ## Project Conventions - Use Makefile targets instead of discovering build/test commands yourself: @@ -25,10 +26,16 @@ spec: - `make update` — update all generated files - `make test` — run all unit tests - `make test-integration` — run integration tests + - e2e tests are hard to run locally. Push changes and use the PR's CI jobs to run them instead - `make build` — build binary - - Always try to add or improve tests when modifying code + - Always try to add or improve tests (including integration, e2e) when modifying code - Logging conventions: start log messages with capital letters and do not end with punctuation - Commit messages: do not include PR links in commit messages + + ## Directory Structure + - `cmd/` — CLI entrypoints + - `test/e2e/` — end-to-end tests + - `.github/workflows/` — CI workflows --- apiVersion: kelos.dev/v1alpha1 kind: TaskSpawner diff --git a/self-development/kelos-triage.yaml b/self-development/kelos-triage.yaml index f15afebf..d2467c22 100644 --- a/self-development/kelos-triage.yaml +++ b/self-development/kelos-triage.yaml @@ -57,7 +57,7 @@ spec: Read the issue carefully and apply exactly one `kind/*` label: - `kind/bug` — something is broken or behaving incorrectly - `kind/feature` — a request for new functionality - - `kind/api` — related to API changes or additions + - `kind/cleanup` — refactoring, technical debt, or configuration alignment - `kind/docs` — documentation improvement or fix Apply the label: diff --git a/self-development/kelos-workers.yaml b/self-development/kelos-workers.yaml index 6bd05e72..b422c4c1 100644 --- a/self-development/kelos-workers.yaml +++ b/self-development/kelos-workers.yaml @@ -17,7 +17,8 @@ spec: ## Standards - Do not create duplicate issues — check existing issues first with `gh issue list` - - Keep changes minimal and focused + - Keep changes minimal and focused. Do not refactor, reorganize, or 'improve' code beyond what was explicitly requested + - For CI/release workflows, always use existing Makefile targets rather than reimplementing build logic in YAML ## Project Conventions - Use Makefile targets instead of discovering build/test commands yourself: @@ -25,10 +26,16 @@ spec: - `make update` — update all generated files - `make test` — run all unit tests - `make test-integration` — run integration tests + - e2e tests are hard to run locally. Push changes and use the PR's CI jobs to run them instead - `make build` — build binary - - Always try to add or improve tests when modifying code + - Always try to add or improve tests (including integration, e2e) when modifying code - Logging conventions: start log messages with capital letters and do not end with punctuation - Commit messages: do not include PR links in commit messages + + ## Directory Structure + - `cmd/` — CLI entrypoints + - `test/e2e/` — end-to-end tests + - `.github/workflows/` — CI workflows --- apiVersion: kelos.dev/v1alpha1 kind: TaskSpawner