Skip to content

Commit 203caac

Browse files
committed
(viewer) Fix small styling mistakes
Some divs are showing empty as gray squares on default screen, hide them if they are not used. Signed-off-by: Denys Fedoryshchenko <denys.f@collabora.com>
1 parent 21d55ca commit 203caac

1 file changed

Lines changed: 12 additions & 4 deletions

File tree

api/templates/viewer.html

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -189,12 +189,16 @@
189189
// hide&clean nodeinfo and requestinfo
190190
var nodeinfo = document.getElementById("nodeinfo");
191191
nodeinfo.innerHTML = "";
192+
nodeinfo.style.display = "none";
192193
var requestinfo = document.getElementById("requestinfo");
193194
requestinfo.innerHTML = "";
195+
requestinfo.style.display = "none";
194196
var miscbuttons = document.getElementById("miscbuttons");
195197
miscbuttons.innerHTML = "";
198+
miscbuttons.style.display = "none";
196199
var nodesearchdiv = document.getElementById("nodesearchdiv");
197200
nodesearchdiv.innerHTML = "";
201+
nodesearchdiv.style.display = "none";
198202
}
199203

200204
function miscclick(event) {
@@ -215,6 +219,7 @@
215219
function addmiscbuttons(data, raw) {
216220
var miscbuttons = document.getElementById("miscbuttons");
217221
var miscbuttonshtml = "";
222+
miscbuttons.style.display = "block";
218223
// do we have parent? then add button to display parent
219224
if (data.parent != null) {
220225
miscbuttonshtml += "<button id=\"parentbutton\" class=\"misc\" href=\"?node_id=" + data.parent + "\">Parent</button>";
@@ -294,6 +299,7 @@
294299
addmiscbuttons(data, request.responseText);
295300
var nodeinfo = document.getElementById("nodeinfo");
296301
var nodeinfohtml = "";
302+
nodeinfo.style.display = "block";
297303
// add pre tag to display json
298304
nodeinfohtml += "<pre>";
299305
nodeinfohtml += fancydisplayjson(request.responseText);
@@ -375,6 +381,7 @@
375381
miscbuttons.innerHTML = "";
376382
miscbuttons.style.display = "none";
377383
var nodeinfo = document.getElementById("nodesearchdiv");
384+
nodeinfo.style.display = "block";
378385
var nodeinfohtml = "<table class=\"nodesearch\">";
379386
var thnames = ["id", "kind", "name", "platform", "state", "result", "created"];
380387
// is data.kernel_revision present? then add to thnames:
@@ -542,6 +549,7 @@
542549
// clear nodeinfo
543550
var nodeinfo = document.getElementById("nodeinfo");
544551
nodeinfo.innerHTML = "";
552+
nodeinfo.style.display = "none";
545553
}
546554

547555
function displayMenu() {
@@ -625,9 +633,9 @@
625633
</div>
626634
<div id="menu">
627635
</div>
628-
<div id="requestinfo"></div>
629-
<div id="miscbuttons"></div>
630-
<div id="nodeinfo"></div>
631-
<div id="nodesearchdiv"></div>
636+
<div id="requestinfo" style="display: none;"></div>
637+
<div id="miscbuttons" style="display: none;"></div>
638+
<div id="nodeinfo" style="display: none;"></div>
639+
<div id="nodesearchdiv" style="display: none;"></div>
632640
</body>
633641
</html>

0 commit comments

Comments
 (0)