Skip to content

feat: support clusterName into service config#4688

Open
leebrouse wants to merge 5 commits into
koderover:mainfrom
leebrouse:feat/service_clusterName
Open

feat: support clusterName into service config#4688
leebrouse wants to merge 5 commits into
koderover:mainfrom
leebrouse:feat/service_clusterName

Conversation

@leebrouse
Copy link
Copy Markdown
Contributor

@leebrouse leebrouse commented May 19, 2026

What this PR does / Why we need it:

What is changed and how it works?

Does this PR introduce a user-facing change?

  • API change
  • database schema change
  • upgrade assistant change
  • change in non-functional attributes such as efficiency or availability
  • fix of a previous issue

This change is Reviewable

Signed-off-by: YuTang Song <2313186065@qq.com>
Signed-off-by: YuTang Song <2313186065@qq.com>
@leebrouse leebrouse requested review from huanghongbo-hhb and removed request for Cynthia-0203 May 22, 2026 05:24
clusterNameCache sync.Map
)

func getClusterName(clusterID string) string {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

没有考虑缓存过期的情况

clusterNameCache sync.Map
)

func getClusterName(clusterID string) string {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

没有考虑缓存过期的情况

leebrouse added 3 commits May 22, 2026 14:02
Signed-off-by: YuTang Song <2313186065@qq.com>
Signed-off-by: YuTang Song <2313186065@qq.com>
Signed-off-by: YuTang Song <2313186065@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants