From f2b5450e38437c5d38ea4e250310e277c9bd5f80 Mon Sep 17 00:00:00 2001 From: kurobon-jp <5210329+kurobon-jp@users.noreply.github.com> Date: Thu, 28 May 2026 16:08:42 +0900 Subject: [PATCH 1/4] Fix logMessageReceivedThreaded --- .github/workflows/octopus.yaml | 71 ++++++++++++++++++++ Assets/Runtime/Scripts/Log/ErrorIndicator.cs | 9 +-- 2 files changed, 74 insertions(+), 6 deletions(-) create mode 100644 .github/workflows/octopus.yaml diff --git a/.github/workflows/octopus.yaml b/.github/workflows/octopus.yaml new file mode 100644 index 0000000..2088ca0 --- /dev/null +++ b/.github/workflows/octopus.yaml @@ -0,0 +1,71 @@ +name: Octopus Review + +on: + pull_request: + types: + - opened + - synchronize + - reopened + +permissions: + contents: read + pull-requests: write + +jobs: + review: + runs-on: ubuntu-latest + + steps: + - name: Run Octopus Review + uses: octopusreview/action@v1 + with: + # Public Repoなら不要 + # Private Repoの場合のみ設定 + # octopus-api-key: ${{ secrets.OCTOPUS_API_KEY }} + + # 日本語レビュー + review-language: "ja" + + # Unity/C#向けチューニング + extra-instructions: | + すべてのレビューコメントを日本語で出力してください。 + + レビューは簡潔にしてください。 + 重大な問題を優先してください。 + + 以下を重点的に確認: + - NullReferenceException の可能性 + - GC Alloc + - Update/LateUpdate/FixedUpdate内の重い処理 + - LINQ多用 + - foreach boxing + - async/await の例外処理 + - async void + - UniTaskの誤用 + - IDisposable/NativeArray の Dispose漏れ + - Addressables誤用 + - Unity main thread問題 + - ScriptableObject誤用 + - イベント購読解除漏れ + - メモリリーク + - パフォーマンス問題 + - マルチスレッド問題 + - URP互換性 + - Shader負荷 + + 以下は指摘しない: + - 命名スタイル + - コメント不足 + - 個人の好みレベルの設計 + - 過剰なリファクタ提案 + - 小さなコードスタイル + - var使用有無 + - 改行位置 + - インデント + - using順 + - trivialな最適化 + + Unity特有の問題を優先してください。 + + 明確な問題のみ指摘してください。 + 推測ベースの指摘は避けてください。 \ No newline at end of file diff --git a/Assets/Runtime/Scripts/Log/ErrorIndicator.cs b/Assets/Runtime/Scripts/Log/ErrorIndicator.cs index ad3837b..8c738bd 100644 --- a/Assets/Runtime/Scripts/Log/ErrorIndicator.cs +++ b/Assets/Runtime/Scripts/Log/ErrorIndicator.cs @@ -19,22 +19,19 @@ protected override void Awake() protected override void OnEnable() { - if (SDSettings.Instance.IsShowErrorIndicator) - { - Application.logMessageReceived += OnLogMessageReceived; - } - + Application.logMessageReceivedThreaded += OnLogMessageReceived; Clear(); } protected override void OnDisable() { - Application.logMessageReceived -= OnLogMessageReceived; + Application.logMessageReceivedThreaded -= OnLogMessageReceived; Clear(); } private void OnLogMessageReceived(string condition, string stackTrace, LogType type) { + if (!SDSettings.Instance.IsShowErrorIndicator) return; if (type is not (LogType.Error or LogType.Exception or LogType.Assert) || _isBlinking) return; HasError = true; StopAllCoroutines(); From abe8b87c1e0ed775b96401fb6e87b9d858f9f265 Mon Sep 17 00:00:00 2001 From: kurobon-jp <5210329+kurobon-jp@users.noreply.github.com> Date: Thu, 28 May 2026 16:48:26 +0900 Subject: [PATCH 2/4] set octopus-api-key --- .github/workflows/octopus.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/octopus.yaml b/.github/workflows/octopus.yaml index 2088ca0..d13c633 100644 --- a/.github/workflows/octopus.yaml +++ b/.github/workflows/octopus.yaml @@ -21,7 +21,7 @@ jobs: with: # Public Repoなら不要 # Private Repoの場合のみ設定 - # octopus-api-key: ${{ secrets.OCTOPUS_API_KEY }} + octopus-api-key: ${{ secrets.OCTOPUS_API_KEY }} # 日本語レビュー review-language: "ja" From 7c4f4a2c4e23c97e0b08c1874c4f82395ed49819 Mon Sep 17 00:00:00 2001 From: kurobon-jp <5210329+kurobon-jp@users.noreply.github.com> Date: Thu, 28 May 2026 16:51:05 +0900 Subject: [PATCH 3/4] instructions --- .github/workflows/octopus.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/octopus.yaml b/.github/workflows/octopus.yaml index d13c633..99f90ab 100644 --- a/.github/workflows/octopus.yaml +++ b/.github/workflows/octopus.yaml @@ -28,7 +28,9 @@ jobs: # Unity/C#向けチューニング extra-instructions: | - すべてのレビューコメントを日本語で出力してください。 + **必ず日本語のみでレビューしてください。英語は使わないでください。** + You MUST respond in Japanese only. Do not use English. + レビューは簡潔にしてください。 重大な問題を優先してください。 From 0aa9265b6a23038f8ae31f67aba360ab70f28879 Mon Sep 17 00:00:00 2001 From: kurobon-jp <5210329+kurobon-jp@users.noreply.github.com> Date: Thu, 28 May 2026 17:10:57 +0900 Subject: [PATCH 4/4] Fix InstantReplay url --- Packages/packages-lock.json | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/Packages/packages-lock.json b/Packages/packages-lock.json index 99122bc..1aa2765 100644 --- a/Packages/packages-lock.json +++ b/Packages/packages-lock.json @@ -71,10 +71,11 @@ } }, "jp.co.cyberagent.instant-replay": { - "version": "file:C:/Users/kurob/Desktop/Unity/ScreenRecord/Packages/InstantReplay/Packages/jp.co.cyberagent.instant-replay", + "version": "https://github.com/CyberAgentGameEntertainment/InstantReplay.git?path=/Packages/jp.co.cyberagent.instant-replay", "depth": 0, - "source": "local", - "dependencies": {} + "source": "git", + "dependencies": {}, + "hash": "e9c51149ddf586c2da5672d8795c68f68925d2b1" }, "jp.co.cyberagent.instant-replay.dependencies": { "version": "https://github.com/CyberAgentGameEntertainment/InstantReplay.git?path=/Packages/jp.co.cyberagent.instant-replay.dependencies",