From 25504975f89d58d9ba5c7856ed26055a9bafff08 Mon Sep 17 00:00:00 2001 From: mccoyp Date: Thu, 8 Jan 2026 18:12:03 +0000 Subject: [PATCH] Implement suggestions --- .../administration/_internal/http_challenge_cache.py | 8 ++++---- .../certificates/_shared/http_challenge_cache.py | 8 ++++---- .../azure/keyvault/keys/_shared/http_challenge_cache.py | 8 ++++---- .../keyvault/secrets/_shared/http_challenge_cache.py | 8 ++++---- .../securitydomain/_internal/http_challenge_cache.py | 9 ++++----- 5 files changed, 20 insertions(+), 21 deletions(-) diff --git a/sdk/keyvault/azure-keyvault-administration/azure/keyvault/administration/_internal/http_challenge_cache.py b/sdk/keyvault/azure-keyvault-administration/azure/keyvault/administration/_internal/http_challenge_cache.py index f1448cc53391..8121884227d0 100644 --- a/sdk/keyvault/azure-keyvault-administration/azure/keyvault/administration/_internal/http_challenge_cache.py +++ b/sdk/keyvault/azure-keyvault-administration/azure/keyvault/administration/_internal/http_challenge_cache.py @@ -59,10 +59,9 @@ def remove_challenge_for_url(url: str) -> None: if not url: raise ValueError("URL cannot be empty") - parsed = parse.urlparse(url) - + key = _get_cache_key(url) with _lock: - del _cache[parsed.netloc] + del _cache[key.lower()] def set_challenge_for_url(url: str, challenge: "HttpChallenge") -> None: @@ -82,8 +81,9 @@ def set_challenge_for_url(url: str, challenge: "HttpChallenge") -> None: if src_url.netloc != challenge.source_authority: raise ValueError("Source URL and Challenge URL do not match") + key = _get_cache_key(url) with _lock: - _cache[src_url.netloc] = challenge + _cache[key.lower()] = challenge def clear() -> None: diff --git a/sdk/keyvault/azure-keyvault-certificates/azure/keyvault/certificates/_shared/http_challenge_cache.py b/sdk/keyvault/azure-keyvault-certificates/azure/keyvault/certificates/_shared/http_challenge_cache.py index f1448cc53391..8121884227d0 100644 --- a/sdk/keyvault/azure-keyvault-certificates/azure/keyvault/certificates/_shared/http_challenge_cache.py +++ b/sdk/keyvault/azure-keyvault-certificates/azure/keyvault/certificates/_shared/http_challenge_cache.py @@ -59,10 +59,9 @@ def remove_challenge_for_url(url: str) -> None: if not url: raise ValueError("URL cannot be empty") - parsed = parse.urlparse(url) - + key = _get_cache_key(url) with _lock: - del _cache[parsed.netloc] + del _cache[key.lower()] def set_challenge_for_url(url: str, challenge: "HttpChallenge") -> None: @@ -82,8 +81,9 @@ def set_challenge_for_url(url: str, challenge: "HttpChallenge") -> None: if src_url.netloc != challenge.source_authority: raise ValueError("Source URL and Challenge URL do not match") + key = _get_cache_key(url) with _lock: - _cache[src_url.netloc] = challenge + _cache[key.lower()] = challenge def clear() -> None: diff --git a/sdk/keyvault/azure-keyvault-keys/azure/keyvault/keys/_shared/http_challenge_cache.py b/sdk/keyvault/azure-keyvault-keys/azure/keyvault/keys/_shared/http_challenge_cache.py index f1448cc53391..8121884227d0 100644 --- a/sdk/keyvault/azure-keyvault-keys/azure/keyvault/keys/_shared/http_challenge_cache.py +++ b/sdk/keyvault/azure-keyvault-keys/azure/keyvault/keys/_shared/http_challenge_cache.py @@ -59,10 +59,9 @@ def remove_challenge_for_url(url: str) -> None: if not url: raise ValueError("URL cannot be empty") - parsed = parse.urlparse(url) - + key = _get_cache_key(url) with _lock: - del _cache[parsed.netloc] + del _cache[key.lower()] def set_challenge_for_url(url: str, challenge: "HttpChallenge") -> None: @@ -82,8 +81,9 @@ def set_challenge_for_url(url: str, challenge: "HttpChallenge") -> None: if src_url.netloc != challenge.source_authority: raise ValueError("Source URL and Challenge URL do not match") + key = _get_cache_key(url) with _lock: - _cache[src_url.netloc] = challenge + _cache[key.lower()] = challenge def clear() -> None: diff --git a/sdk/keyvault/azure-keyvault-secrets/azure/keyvault/secrets/_shared/http_challenge_cache.py b/sdk/keyvault/azure-keyvault-secrets/azure/keyvault/secrets/_shared/http_challenge_cache.py index f1448cc53391..8121884227d0 100644 --- a/sdk/keyvault/azure-keyvault-secrets/azure/keyvault/secrets/_shared/http_challenge_cache.py +++ b/sdk/keyvault/azure-keyvault-secrets/azure/keyvault/secrets/_shared/http_challenge_cache.py @@ -59,10 +59,9 @@ def remove_challenge_for_url(url: str) -> None: if not url: raise ValueError("URL cannot be empty") - parsed = parse.urlparse(url) - + key = _get_cache_key(url) with _lock: - del _cache[parsed.netloc] + del _cache[key.lower()] def set_challenge_for_url(url: str, challenge: "HttpChallenge") -> None: @@ -82,8 +81,9 @@ def set_challenge_for_url(url: str, challenge: "HttpChallenge") -> None: if src_url.netloc != challenge.source_authority: raise ValueError("Source URL and Challenge URL do not match") + key = _get_cache_key(url) with _lock: - _cache[src_url.netloc] = challenge + _cache[key.lower()] = challenge def clear() -> None: diff --git a/sdk/keyvault/azure-keyvault-securitydomain/azure/keyvault/securitydomain/_internal/http_challenge_cache.py b/sdk/keyvault/azure-keyvault-securitydomain/azure/keyvault/securitydomain/_internal/http_challenge_cache.py index f1448cc53391..4a3707635498 100644 --- a/sdk/keyvault/azure-keyvault-securitydomain/azure/keyvault/securitydomain/_internal/http_challenge_cache.py +++ b/sdk/keyvault/azure-keyvault-securitydomain/azure/keyvault/securitydomain/_internal/http_challenge_cache.py @@ -59,11 +59,9 @@ def remove_challenge_for_url(url: str) -> None: if not url: raise ValueError("URL cannot be empty") - parsed = parse.urlparse(url) - + key = _get_cache_key(url) with _lock: - del _cache[parsed.netloc] - + del _cache[key.lower()] def set_challenge_for_url(url: str, challenge: "HttpChallenge") -> None: """Caches the challenge for the specified URL. @@ -82,8 +80,9 @@ def set_challenge_for_url(url: str, challenge: "HttpChallenge") -> None: if src_url.netloc != challenge.source_authority: raise ValueError("Source URL and Challenge URL do not match") + key = _get_cache_key(url) with _lock: - _cache[src_url.netloc] = challenge + _cache[key.lower()] = challenge def clear() -> None: