build: package alsaaudio properly and ship typing stubs#161
Open
Robolightning wants to merge 1 commit into
Open
build: package alsaaudio properly and ship typing stubs#161Robolightning wants to merge 1 commit into
Robolightning wants to merge 1 commit into
Conversation
Collaborator
|
looks sensible judging by a quick inspection. given the bullet list, it seem that this PR can be atomized into a series of self-contained commits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors
pyalsaaudiointo a proper package-based layout and fixes distribution of typing metadata.Changes
alsaaudio._alsaaudioalsaaudio/__init__.pyto preserve the public APIpy.typedMotivation
Previously, the stubs were not installed correctly, because the project was packaged as a standalone extension module rather than a regular package. This change makes typing support work reliably and keeps installation behavior cleaner across platforms.