Imagine that you are developer tasked with reviewing a colleague's pull request. The Overview and Feature Requirements will give context into the goals and acceptance criteria that your colleague had when he wrote the code. After reading the readme, peer review the pull request.
Our team has been tasked with creating the backend for a small bookmarking system. Users can save and retrieve URLs from several places and devices.
We must deploy this feature as soon as possible; As this will be the foundation for all future development efforts, we need you to make sure this code is the best it can be.
IMPORTANT: This application is purely for code review only. This is by no means a functional application. As a result, pretend that this actually is a user-facing, production application, and that the pull request is simply adding the bookmarking feature to it.
- Users should be able to save an URL.
- When an URL is submitted, we should get and save its metadata using this API
- Users should be able to submit a list of URLs.
- Users should be able to search their urls by name.
- Users should be able to mark individual urls as favorites.
- Users should be able to retrieve all their URLs.
- Users should be able to retrieve all their favorite URLs.
Review the code changes below for the following:
- Syntax errors
- Inefficiencies
- Ways to improve the code
- Feature requirements were met
(Do not comment on the pull request).
Compile your feedback, including explanations as to why something is wrong/inefficient and how can it be improved, and email it to tech@latchel.com
Feel free to ask questions! If you need clarification or additional context to help you properly review this pull request, feel free to email tech@latchel.com.