Skip to content

Latchel Code Challenge - Peer Review#6

Open
jullian-chavez wants to merge 5 commits into
feature/jc/code-reviewfrom
feature/jc/code-review-pr
Open

Latchel Code Challenge - Peer Review#6
jullian-chavez wants to merge 5 commits into
feature/jc/code-reviewfrom
feature/jc/code-review-pr

Conversation

@jullian-chavez

@jullian-chavez jullian-chavez commented Mar 14, 2017

Copy link
Copy Markdown
Contributor

Overview

As a developer, I have been tasked with adding a list of blog posts to the homepage of this faux, blog-like application. Below is my mock pull request for this feature. I have assigned this pull request to you for peer review!

IMPORTANT: This application is purely for code review only. This is by no means a functional application. As a result, pretend that this actually is a user-facing, production application, and that the pull request is simply adding a feature to it.

Feature Requirements

  • Users should be able to see a list of blog posts on the home page
  • Blog posts should be collapsed by default (body content of the blog post should be hidden)
  • Clicking on the post's author's name should toggle whether the post is collapsed

Task for you

  • Review the code changes in this PR for the following:
    • Syntax errors
    • Inefficiencies
    • Improper design patterns
    • Feature requirements were met
  • Compile your feedback, including explanations as to why something is wrong/inefficient, and email it to tech@latchel.com (Do not comment on this pull request or submit a pull request here. Other candidates can see your submission, which defeats the purpose of this exercise).

Final Thoughts

  • Feel free to ask questions! If you need clarification or additional context to help you properly review this pull request, feel free to email tech@latchel.com.

@latchel latchel locked and limited conversation to collaborators Mar 14, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant