Skip to content

fix: remediate high & critical Dependabot vulnerabilities#163

Merged
pkaeding merged 2 commits into
mainfrom
devin/1780953289-fix-dependabot-vulns
Jun 9, 2026
Merged

fix: remediate high & critical Dependabot vulnerabilities#163
pkaeding merged 2 commits into
mainfrom
devin/1780953289-fix-dependabot-vulns

Conversation

@pkaeding

@pkaeding pkaeding commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Summary

Upgrades vulnerable dependencies to resolve high and critical Dependabot alerts.

Direct dependency upgrades:

  • axios ^1.12.0 → ^1.17.0 (SSRF, prototype pollution, credential leak, ReDoS)
  • lodash ^4.17.23 → ^4.18.0 (code injection via _.template)
  • mocha 10.2.0 → 10.8.2 (fixes transitive minimatch/serialize-javascript vulns)

Yarn resolutions added for transitive deps pinned to vulnerable versions by parent packages:

  • braces, picomatch, fast-uri, flatted, handlebars, serialize-javascript, @xmldom/xmldom, request/form-data

Lockfile updates for minimatch (3.1.2→3.1.5, 5.1.6→5.1.9).

Remaining (unfixable without major version bumps of intermediate devDeps):

  • glob (needs 10.x, pinned at 7/8.x by @twbs/fantasticon, @vscode/test-cli)
  • tar (needs 7.x, pinned at 6.x by node-gyp in @twbs/fantasticon)
  • minimatch 9.x (9.0.6+ requires brace-expansion 5.x which breaks ESM/CJS interop in @vscode/test-cli)"

Link to Devin session: https://app.devin.ai/sessions/1e6ae06a2bc34abe9a8d6671f567fef8
Requested by: @pkaeding

- Upgrade axios from ^1.12.0 to ^1.17.0 (fixes SSRF, prototype pollution, credential leak, ReDoS)
- Upgrade lodash from ^4.17.23 to ^4.18.0 (fixes code injection via _.template)
- Upgrade mocha from 10.2.0 to 10.8.2 (fixes transitive minimatch/serialize-javascript vulns)
- Add yarn resolutions for transitive dependencies:
  braces, picomatch, fast-uri, flatted, handlebars,
  serialize-javascript, @xmldom/xmldom, form-data
- Update lockfile minimatch entries (3.x→3.1.5, 5.x→5.1.9, 9.x→9.0.7)

Remaining unfixable: glob (needs 10.x, pinned at 7/8.x by parent devDeps)
and tar (needs 7.x, pinned at 6.x by node-gyp in fantasticon).

Co-Authored-By: Patrick Kaeding <patrick@kaeding.name>
@devin-ai-integration

Copy link
Copy Markdown
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

@pkaeding pkaeding requested review from a team and charlottemorgan June 8, 2026 21:23
Comment thread yarn.lock
argparse "^1.0.7"
esprima "^4.0.0"

js-yaml@^4.1.0:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Medium severity vulnerability may affect your project—review required:
Line 3932 lists a dependency (js-yaml) with a known Medium severity vulnerability.

ℹ️ Why this matters

Affected versions of js-yaml are vulnerable to Improperly Controlled Modification of Object Prototype Attributes ('Prototype Pollution'). js-yaml is vulnerable to prototype pollution through its YAML merge key (<<) handling. When parsing untrusted YAML with load, loadAll, safeLoad, or safeLoadAll, a crafted document containing a __proto__ key inside a merged mapping can modify the prototype of the resulting object, leading to integrity violations in the application.

References: GHSA, CVE

To resolve this comment:
Check if you are using js-yaml on the CLI.

  • If you're affected, upgrade this dependency to at least version 4.1.1 at yarn.lock.
  • If you're not affected, comment /fp we don't use this [condition]
💬 Ignore this finding

To ignore this, reply with:

  • /fp <comment> for false positive
  • /ar <comment> for acceptable risk
  • /other <comment> for all other reasons

You can view more details on this finding in the Semgrep AppSec Platform here.

@pkaeding pkaeding marked this pull request as ready for review June 8, 2026 21:24
minimatch 9.0.6+ requires brace-expansion ^5.0.2 which breaks the
ESM/CJS interop in @vscode/test-cli. Keeping 9.0.5 for now.

Co-Authored-By: Patrick Kaeding <patrick@kaeding.name>
@pkaeding pkaeding merged commit f508672 into main Jun 9, 2026
4 checks passed
@pkaeding pkaeding deleted the devin/1780953289-fix-dependabot-vulns branch June 9, 2026 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants