Chore: add path filters to testing.yaml for pull_request trigger#182
Open
askb wants to merge 1 commit into
Open
Chore: add path filters to testing.yaml for pull_request trigger#182askb wants to merge 1 commit into
askb wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
Adds path-based filtering to the testing.yaml pull_request trigger to avoid running the full test workflow for Dependabot PRs that only change workflow/config files.
Changes:
- Adds
pathsfiltering underon.pull_requestin.github/workflows/testing.yamlto attempt skipping runs when only.github/**, dotfiles, ortox.inichange.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Problem:
The testing.yaml workflow triggers on ALL pull_request events regardless
of which files changed. Across the lfreleng-actions org, 75% of
Dependabot PRs (74 of 98 at last audit) only bump SHA pins in
.github/workflows/ files — yet each one triggers the full integration
test suite unnecessarily.
This wastes 65%+ of CI compute on test runs that can never catch a
regression because no source code, dependencies, or tests changed.
Solution:
Add path filters using the same denylist (opt-out) convention already
used by build-test.yaml across the org (dependamerge, gerrit-clone-action,
gha-workflow-linter, lftools-uv, github2gerrit-action):
paths:
- '**'
- '!.github/**'
- '!.*'
- '!tox.ini'
This approach:
- Matches the existing org convention
- Fails open (worst case: a few extra CI minutes) rather than failing
closed (allowlist silently stops running tests if layout changes)
- Is universal and templatable from actions-template without per-repo
customization across 55+ repos of varying languages
Impact:
- Before: Every Dependabot PR triggers full integration tests
- After: Only source/dependency changes trigger tests
- Savings: ~65% reduction in unnecessary CI compute
Signed-off-by: Anil Belur <askb23@gmail.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
askb
force-pushed
the
fix/testing-path-filters
branch
from
c05ed34 to
fd5dcfb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add path filters to
testing.yamlso Dependabot PRs that only bump SHA pins in.github/workflows/skip the full test suite.Why This Is Needed
Approach: Denylist (Org Convention)
Uses the same opt-out pattern already established across the org:
Impact
Part of org-wide Dependabot CI optimization initiative.