DnD input files crashes the app

[ryonakano]

What Happened?

Drag & Drop input files causes the app crash without no logs.

I think your app may not get necessary permission to read the dragged files because:

• opening input files from the open button in the header bar does not trigger this issue
• giving permission to the home folder for Hash-it does not trigger this issue
  

Steps to Reproduce

1. Open Hash-it
2. Drag & Drop files from Files onto the Drag & Drop File(s) label
3. See the app crashes immediatelly

Expected Behavior

Drag & Drop input files shows their hash instead of crashing.

Info

• elementary OS 8.x Early Access with Classic Session
• Hash-it installed from git using flatpak-builder: d8b29a7 (tag 0.1.2)

Log Output

N/A

Hardware Info

I use KVM on virt-manager

[libredeb]

Hi @ryonakano

I've tried to reproduce this issue in a live environment (using qemu with kvm) without success.

I've attached a recording of the desktop to show you my steps in order:
https://github.com/user-attachments/assets/93b2677a-eaf4-4ae5-9949-d26d85dd59d8

However, do you know if there's a class in Gtk or Granite that allows me to evaluate whether these permissions exist or not and ask the user if they want to enable them? I'd like to explore that further.

[ryonakano]

@libredeb I guess you installed Hash-it nativelly instead of via Flatpak? If so this issue won't happen.

[libredeb]

@ryonakano you are right, my bad. I've installed it in native manner but if I build and run the app as flatpak package this issue occur. I was able to solve the issue adding next line to the flatpak manifest but I'm not sure if I breaking the sandboxing of my app:

What do you think?

[ryonakano]

@libredeb Sorry, I haven't been able to take time to dig into this issue yet, but we shouldn't definitely use the above sandbox hole as I commented in elementary/appcenter-reviews#588 (review).

[libredeb]

@ryonakano I guess this issue can be marked as resolved by what was added in the last commit. Right?

[ryonakano]

@libredeb The app still crashes if you drag and drop files from places other than the home directory, so we should prevent that too. I opened #7 to fix the crash, could you check it works for you too?

[libredeb]

@ryonakano thank you for the enormous help with the pull-requests that you are providing.

When you says "drag and drop files from places other than the home directory", which ones are you referring to? Could you give me some examples? I've tried to replicate this last case on my elementary OS installation, but I haven't been able to replicate it (it works fine for me).

[ryonakano]

When you says "drag and drop files from places other than the home directory", which ones are you referring to? Could you give me some examples?

@libredeb You should be able to reproduce the crash by installing 24044e8 (the revision before merging #7) with flatpak-builder and dragging a file under /tmp or external storages (which is mounted under /media). However, this is fixed in #7 (now the app shows an error toast instead of crashing in such cases) so we can close this issue.

[libredeb]

@ryonakano ok, but /tmp and /media are outside the scope of what the added property --filesystem=home defines in that commit. In that case, do you think that will be convenient to add those specific paths to the allow list declared in flatpak's specification?

[ryonakano]

@libredeb Sorry, I didn't reply to your question.

do you think that will be convenient to add those specific paths to the allow list declared in flatpak's specification?

No, I don't think that's necessary because most users wouldn't drag and drop files from /tmp or external storages. The app used to crash, which was not acceptable in general, when users do that previously, but now it won't and shows an error toast so I think it's fine.