From 9b74bacfbec3a2f75d3e9ab5abba0ff8949e67f1 Mon Sep 17 00:00:00 2001 From: xtqqczze <45661989+xtqqczze@users.noreply.github.com> Date: Wed, 15 Jul 2026 14:41:40 +0100 Subject: [PATCH 1/2] clippy: fix unnecessary_sort_by lint https://rust-lang.github.io/rust-clippy/rust-1.97.0/index.html#unnecessary_sort_by --- metadata/src/audio/item.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/metadata/src/audio/item.rs b/metadata/src/audio/item.rs index 2386fa21a..d44d27a40 100644 --- a/metadata/src/audio/item.rs +++ b/metadata/src/audio/item.rs @@ -194,7 +194,7 @@ impl AudioItem { fn get_covers(covers: Images, image_url: String) -> Vec { let mut covers = covers; - covers.sort_by(|a, b| b.width.cmp(&a.width)); + covers.sort_by_key(|a| std::cmp::Reverse(a.width)); covers .iter() From 01316b03efa79c3a0d8a750753db20493245a4a9 Mon Sep 17 00:00:00 2001 From: xtqqczze <45661989+xtqqczze@users.noreply.github.com> Date: Wed, 15 Jul 2026 14:45:36 +0100 Subject: [PATCH 2/2] clippy: fix useless_borrows_in_formatting lint https://rust-lang.github.io/rust-clippy/rust-1.97.0/index.html#useless_borrows_in_formatting --- core/src/dealer/mod.rs | 6 +++--- core/src/mercury/mod.rs | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/core/src/dealer/mod.rs b/core/src/dealer/mod.rs index 63ee6e72c..ebaeeedd1 100644 --- a/core/src/dealer/mod.rs +++ b/core/src/dealer/mod.rs @@ -369,7 +369,7 @@ impl DealerShared { request: WebsocketRequest, send_tx: &mpsc::UnboundedSender, ) { - trace!("dealer request {}", &request.message_ident); + trace!("dealer request {}", request.message_ident); let payload_request = match request.handle_payload() { Ok(payload) => payload, @@ -387,7 +387,7 @@ impl DealerShared { } else { warn!( "Dealer request with invalid message_ident: {}", - &request.message_ident + request.message_ident ); return; }; @@ -402,7 +402,7 @@ impl DealerShared { return; } - warn!("No handler for message_ident: {}", &request.message_ident); + warn!("No handler for message_ident: {}", request.message_ident); } fn dispatch(&self, m: MessageOrRequest, send_tx: &mpsc::UnboundedSender) { diff --git a/core/src/mercury/mod.rs b/core/src/mercury/mod.rs index b32aeb11d..8b04e73f6 100644 --- a/core/src/mercury/mod.rs +++ b/core/src/mercury/mod.rs @@ -237,10 +237,10 @@ impl MercuryManager { let status_code = response.status_code; if status_code >= 500 { - error!("error {} for uri {}", status_code, &response.uri); + error!("error {} for uri {}", status_code, response.uri); Err(MercuryError::Response(response).into()) } else if status_code >= 400 { - error!("error {} for uri {}", status_code, &response.uri); + error!("error {} for uri {}", status_code, response.uri); if let Some(cb) = pending.callback { cb.send(Err(MercuryError::Response(response.clone()).into())) .map_err(|_| MercuryError::Channel)?; @@ -282,7 +282,7 @@ impl MercuryManager { trace!("mercury response <{}> is handled by dealer", response.uri); Ok(()) } else { - debug!("unknown subscription uri={}", &response.uri); + debug!("unknown subscription uri={}", response.uri); trace!("response pushed over Mercury: {response:?}"); Err(MercuryError::Response(response).into()) }