Skip to content

Commit 4c2a5e1

Browse files
committed
TPT-4278: python-sdk: Implement support for Reserved IP for IPv4
1 parent 3535a89 commit 4c2a5e1

2 files changed

Lines changed: 4 additions & 3 deletions

File tree

linode_api4/groups/nodebalancer.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ def __call__(self, *filters):
2424
"""
2525
return self.client._get_and_filter(NodeBalancer, *filters)
2626

27-
def create(self, region, ipv4=None, **kwargs):
27+
def create(self, region, **kwargs):
2828
"""
2929
Creates a new NodeBalancer in the given Region.
3030
@@ -39,6 +39,7 @@ def create(self, region, ipv4=None, **kwargs):
3939
:returns: The new NodeBalancer
4040
:rtype: NodeBalancer
4141
"""
42+
ipv4 = kwargs.pop("ipv4", None)
4243
params = {
4344
"region": region.id if isinstance(region, Base) else region,
4445
}
@@ -50,7 +51,7 @@ def create(self, region, ipv4=None, **kwargs):
5051

5152
if not "id" in result:
5253
raise UnexpectedResponseError(
53-
"Unexpected response when creating Nodebalaner!", json=result
54+
"Unexpected response when creating NodeBalancer!", json=result
5455
)
5556

5657
n = NodeBalancer(self.client, result["id"], result)

linode_api4/groups/tag.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,8 @@ def create(
3232
domains=None,
3333
nodebalancers=None,
3434
volumes=None,
35-
reserved_ipv4_addresses=None,
3635
entities=None,
36+
reserved_ipv4_addresses=None,
3737
):
3838
"""
3939
Creates a new Tag and optionally applies it to the given entities.

0 commit comments

Comments
 (0)