From c0c1508e3c45777fb56b46529b173362c04972b1 Mon Sep 17 00:00:00 2001 From: Daniel Wagner Date: Tue, 7 Jul 2026 20:16:40 +0200 Subject: [PATCH] build: use ci-containers for linters Run the linters on different distros, to cover more ground. Signed-off-by: Daniel Wagner --- .github/workflows/python-sanity.yml | 30 ++++++++++++++--------------- 1 file changed, 14 insertions(+), 16 deletions(-) diff --git a/.github/workflows/python-sanity.yml b/.github/workflows/python-sanity.yml index 531c538..dd5b953 100644 --- a/.github/workflows/python-sanity.yml +++ b/.github/workflows/python-sanity.yml @@ -15,27 +15,25 @@ on: jobs: lint: - name: Lint + name: Lint (${{ matrix.container }}) runs-on: ubuntu-latest - steps: - - uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0 + strategy: + fail-fast: false + matrix: + container: + - ghcr.io/linux-nvme/nvmetcli-debian:latest + - ghcr.io/linux-nvme/nvmetcli-fedora:latest + - ghcr.io/linux-nvme/nvmetcli-tumbleweed:latest - - name: Set up Python - uses: actions/setup-python@ece7cb06caefa5fff74198d8649806c4678c61a1 # v6.3.0 - with: - python-version: "3.11" + container: + image: ${{ matrix.container }} - - name: Install dependencies - run: | - python -m pip install --upgrade pip - pip install flake8 pylint + steps: + - uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0 - name: flake8 - run: flake8 nvmet/ nvmetcli + run: python3 -m flake8 nvmet/ nvmetcli - name: pylint - run: pylint --disable=all --enable=E nvmet/ nvmetcli - - - name: Verify package installs - run: pip install . + run: python3 -m pylint --disable=all --enable=E nvmet/ nvmetcli