Skip to content

Broken pnp.ids file in sources #146

@pinotree

Description

@pinotree

The file libcinnamon-desktop/pnp.ids is an HTML file, most probably the result of a downloading script with an outdated URL. Hence, unless the pnp_ids meson option with a path is specified, libcinnamon-desktop will attempt to use a broken file.

This opens a slightly bigger discussion: considering that

  • pnp.ids is provided by hwdata which is widely available in Linux (and not only) distros (see https://repology.org/project/hwdata/versions)
  • libcinnamon-desktop/gnome-pnp-ids.c has some sort of fallback list of vendors to use in case it is not found in pnp.ids: I see few that are not even in recent pnp.ids

my ideas are the following:

  • require a system version of pnp.ids, either by mandating the use of the pnp_ids meson option or having a list of predefined locations (e.g. /usr/share/hwdata/pnp.ids) where to look for
  • drop the own pnp.ids file from the sources, along with the logic to install it and use it from the own datadir
  • trim (or even drop) the own list of vendors in gnome-pnp-ids.c

What do you think?

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions