Skip to content

Commit 89530b5

Browse files
rm unused/broken log_sink for future proofing
1 parent f0db076 commit 89530b5

16 files changed

Lines changed: 19 additions & 27 deletions

docs/doxygen/index.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ Build real-time audio/video applications in C++ with LiveKit.
99

1010
bool initializeLivekit(const std::string& url, const std::string& token) {
1111
// Init LiveKit
12-
livekit::initialize(livekit::LogLevel::Info, livekit::LogSink::kConsole);
12+
livekit::initialize(livekit::LogLevel::Info);
1313

1414
room_ = std::make_unique<livekit::Room>();
1515
livekit::RoomOptions options;

include/livekit/livekit.h

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -44,25 +44,16 @@
4444
/// @brief Public API for the LiveKit C++ Client SDK.
4545
namespace livekit {
4646

47-
/// The log sink to use for SDK messages.
48-
enum class LogSink {
49-
/// Log messages to the console.
50-
kConsole = 0,
51-
/// Log messages to a callback function.
52-
kCallback = 1,
53-
};
54-
5547
/// Initialize the LiveKit SDK.
5648
///
5749
/// This **must be the first LiveKit API called** in the process.
5850
/// It configures global SDK state, including log routing.
5951
///
6052
/// @param level Minimum log level for SDK messages (default: Info).
6153
/// Use setLogLevel() to change at runtime.
62-
/// @param log_sink The log sink to use for SDK messages (default: Console).
6354
/// @returns true if initialization happened on this call, false if it was
6455
/// already initialized.
65-
LIVEKIT_API bool initialize(const LogLevel& level = LogLevel::Info, const LogSink& log_sink = LogSink::kConsole);
56+
LIVEKIT_API bool initialize(const LogLevel& level = LogLevel::Info);
6657

6758
/// Shut down the LiveKit SDK.
6859
///

src/livekit.cpp

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,12 @@
2121

2222
namespace livekit {
2323

24-
bool initialize(const LogLevel& level, const LogSink& log_sink) {
24+
bool initialize(const LogLevel& level) {
2525
// Initializes logger if singleton instance is not already initialized
2626
setLogLevel(level);
2727
auto& ffi_client = FfiClient::instance();
28-
return ffi_client.initialize(log_sink == LogSink::kCallback);
28+
// Note: capture_logs currently disabled, requires event support in FfiClient
29+
return ffi_client.initialize(false);
2930
}
3031

3132
bool isInitialized() { return FfiClient::instance().isInitialized(); }

src/tests/common/test_common.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -497,7 +497,7 @@ class StressTestStats {
497497
class LiveKitTestBase : public ::testing::Test {
498498
protected:
499499
void SetUp() override {
500-
livekit::initialize(livekit::LogLevel::Info, livekit::LogSink::kConsole);
500+
livekit::initialize(livekit::LogLevel::Info);
501501
config_ = TestConfig::fromEnv();
502502

503503
// Tracing is controlled by compile-time macro LIVEKIT_TEST_ENABLE_TRACING

src/tests/integration/test_room.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ namespace livekit::test {
2929
class RoomTest : public ::testing::Test {
3030
protected:
3131
void SetUp() override {
32-
livekit::initialize(livekit::LogLevel::Info, livekit::LogSink::kConsole);
32+
livekit::initialize(livekit::LogLevel::Info);
3333

3434
const char* url_env = std::getenv("LIVEKIT_URL");
3535
const char* token_env = std::getenv("LIVEKIT_TOKEN_A");

src/tests/integration/test_rpc.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ std::string generateRandomPayload(size_t size) {
9393
class RpcIntegrationTest : public ::testing::Test {
9494
protected:
9595
void SetUp() override {
96-
livekit::initialize(livekit::LogLevel::Info, livekit::LogSink::kConsole);
96+
livekit::initialize(livekit::LogLevel::Info);
9797
config_ = RpcTestConfig::fromEnv();
9898
}
9999

src/tests/stress/test_audio_frame_stress.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ namespace livekit::test {
2727

2828
class AudioFrameStressTest : public ::testing::Test {
2929
protected:
30-
void SetUp() override { livekit::initialize(livekit::LogLevel::Info, livekit::LogSink::kConsole); }
30+
void SetUp() override { livekit::initialize(livekit::LogLevel::Info); }
3131

3232
void TearDown() override { livekit::shutdown(); }
3333
};

src/tests/stress/test_room_stress.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ namespace livekit::test {
2727

2828
class RoomStressTest : public ::testing::Test {
2929
protected:
30-
void SetUp() override { livekit::initialize(livekit::LogLevel::Info, livekit::LogSink::kConsole); }
30+
void SetUp() override { livekit::initialize(livekit::LogLevel::Info); }
3131

3232
void TearDown() override { livekit::shutdown(); }
3333
};
@@ -176,7 +176,7 @@ TEST_F(RoomStressTest, StreamHandlerRegistrationStress) {
176176
class RoomServerStressTest : public ::testing::Test {
177177
protected:
178178
void SetUp() override {
179-
livekit::initialize(livekit::LogLevel::Info, livekit::LogSink::kConsole);
179+
livekit::initialize(livekit::LogLevel::Info);
180180

181181
const char* url_env = std::getenv("LIVEKIT_URL");
182182
const char* token_env = std::getenv("LIVEKIT_TOKEN_A");

src/tests/unit/test_audio_frame.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ namespace livekit::test {
2222

2323
class AudioFrameTest : public ::testing::Test {
2424
protected:
25-
void SetUp() override { livekit::initialize(livekit::LogLevel::Info, livekit::LogSink::kConsole); }
25+
void SetUp() override { livekit::initialize(livekit::LogLevel::Info); }
2626

2727
void TearDown() override { livekit::shutdown(); }
2828
};

src/tests/unit/test_audio_processing_module.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ namespace livekit::test {
3232

3333
class AudioProcessingModuleTest : public ::testing::Test {
3434
protected:
35-
void SetUp() override { livekit::initialize(livekit::LogLevel::Info, livekit::LogSink::kConsole); }
35+
void SetUp() override { livekit::initialize(livekit::LogLevel::Info); }
3636

3737
void TearDown() override { livekit::shutdown(); }
3838

0 commit comments

Comments
 (0)