[lldb][test] Link test binaries with -random_uuid#199385
Open
kastiglione wants to merge 1 commit into
Open
Conversation
|
@llvm/pr-subscribers-lldb Author: Dave Lee (kastiglione) ChangesFull diff: https://github.com/llvm/llvm-project/pull/199385.diff 1 Files Affected:
diff --git a/lldb/packages/Python/lldbsuite/test/make/Makefile.rules b/lldb/packages/Python/lldbsuite/test/make/Makefile.rules
index 1ec9b420e3f36..44aa91ef7b6fc 100644
--- a/lldb/packages/Python/lldbsuite/test/make/Makefile.rules
+++ b/lldb/packages/Python/lldbsuite/test/make/Makefile.rules
@@ -209,6 +209,10 @@ ifeq "$(OS)" "Darwin"
DSFLAGS := $(DSFLAGS_EXTRAS)
DSYM = $(EXE).dSYM
ARFLAGS := -static -o
+ # The default UUID is a hash based on filename and __text section content.
+ # Use a random UUID so that LLDB and Spotlight never confuse two test
+ # binaries, where repeated test code can result in identical binaries.
+ LDFLAGS += -Wl,-random_uuid
else
ifeq "$(SPLIT_DEBUG_SYMBOLS)" "YES"
DSYM = $(EXE).debug
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While reviewing #197237, it occurred to me that
-random_uuidcould be an alternative solution to problem that was solved by adding a ".noindex" suffix to the lldb-test-build directory name.