Skip to content

Remove unused ReadProfileV0 and fix template location issue#199399

Open
corbettknowles wants to merge 4 commits into
llvm:mainfrom
corbettknowles:main
Open

Remove unused ReadProfileV0 and fix template location issue#199399
corbettknowles wants to merge 4 commits into
llvm:mainfrom
corbettknowles:main

Conversation

@corbettknowles
Copy link
Copy Markdown

No description provided.

removed ReadProfileV0 from the header it was a unused function and had deprecated i verified that wasnt being called in the corresponding .cpp the ReadprofileV1 is the only being used
line 73 had getFileLoc(loc) not recommended for template types it wrong instentation it follows the template chain back to wrong location i replaced it with getExpansionLoc(Loc) which is the correct instentation and fixes the broken explicit and implicit
@github-actions
Copy link
Copy Markdown

Hello @corbettknowles 👋

Thank you for submitting a Pull Request (PR) to the LLVM Project. Since this is your first PR, here are a few useful links covering our main contribution policies and review practices.

  • All contributions to LLVM must follow our LLVM AI Tool Use Policy. In particular, if you used AI while working on this PR, remember to add a note to the PR description.
  • The LLVM Code-Review Policy and Practices document contains practical information about the PR process, including how patches are reviewed and accepted, and who can review a PR.
  • Our LLVM Developer Policy describes our expectations for code quality, commit summaries and contains notes on our CI system.

Please reply to this message to confirm that you have read these policies, especially the LLVM AI Tool Use Policy, and that any AI tool usage has been noted in the PR description.


Frequently asked questions

How do I add reviewers?

This PR will be automatically labeled, and the relevant teams will be notified. For some parts of the project, reviewers may also be added automatically.

You can also add reviewers manually using the Reviewers section on this page. If you cannot use that section, it is probably because you do not have write permissions for the repository. In that case, you can request a review by tagging reviewers in a comment using @ followed by their GitHub username.

What if there are no comments?

If you have not received any comments on your PR after a week, you can request a review by pinging the PR with a comment such as “Ping”. The common courtesy ping rate is once a week. Please remember that you are asking for volunteer time from other developers.

Are any special GitHub settings required to contribute to LLVM?

We only require contributors to have a public email address associated with their GitHub commits, see this section of LLVM Developer Policy for details.


If you have questions, feel free to leave a comment on this PR, or ask on LLVM Discord or LLVM Discourse.

Thank you,
The LLVM Community

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant