Skip to content

fix: add type-safe preset names to HapticInput #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abed-daloopa wants to merge 3 commits into
base: main
Choose a base branch
from
+10 −1
Open

fix: add type-safe preset names to HapticInput #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5f5f97a
fix: add autocomplete types for default haptic pattern names
abed-daloopa Apr 6, 2026
44e4d1a
fix: add autocomplete types for default haptic pattern names
abed-daloopa Apr 6, 2026
74e97ea
fix: restore runtime guard for unknown preset names
abed-daloopa Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/web-haptics/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ export { version } from "./../package.json";

export { WebHaptics } from "./lib/web-haptics";
export { defaultPatterns } from "./lib/web-haptics/patterns";
export type { DefaultPatternName } from "./lib/web-haptics/patterns";
export type {
Vibration,
HapticPattern,
Expand Down
2 changes: 2 additions & 0 deletions packages/web-haptics/src/lib/web-haptics/patterns.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,3 +67,5 @@ export const defaultPatterns = {
pattern: [{ duration: 1000, intensity: 1 }],
},
} as const satisfies Record<string, HapticPreset>;

export type DefaultPatternName = keyof typeof defaultPatterns;
8 changes: 7 additions & 1 deletion packages/web-haptics/src/lib/web-haptics/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import type { DefaultPatternName } from "./patterns";

export interface Vibration {
duration: number;
intensity?: number;
Expand All @@ -10,7 +12,11 @@ export interface HapticPreset {
pattern: Vibration[];
}

export type HapticInput = number | string | HapticPattern | HapticPreset;
export type HapticInput =
| number
| DefaultPatternName
| HapticPattern
| HapticPreset;

export interface TriggerOptions {
intensity?: number;
Expand Down