Delete "static data"

[jder]

I think this is only used for correctors, which we're not using. @fomo-bot can you please verify that and if so please put up a PR to delete this after #670 lands.

[fomo-bot]

Verified: the runtime static_data plumbing is only there for correctors, specifically the ocean_heat_corrector path. Current configs set static_data_vars: [] and ocean_heat_corrector: false, so there does not appear to be an active non-corrector use.



I did not open the deletion PR yet because #670 is still open, unmerged, review-required, and currently marked conflicting by GitHub. Once #670 lands, the next action is to branch from updated main, remove the static_data_vars/DataContainer.static_data/static_data_for_corrector plumbing and related config/test leftovers, validate, and open a PR referencing #816.

Debug info

• Repository: m2lines/Samudra
• Trigger: Delete "static data" #816
• Request ID: f5dc3619-7a07-4d2a-9427-e2c1ce6adc6c
• Accepted: true

[jder]

@fomo-bot to be clear, we should also delete the correctors while doing this.

[fomo-bot]

Accepted. I’ll include deleting the correctors in the #816 cleanup scope, not just the static-data plumbing. That means removing the corrector implementation/config surface and related tests/config blocks along with static_data_vars, DataContainer.static_data, and static_data_for_corrector.



I rechecked #670: it is still open, unmerged, review-required, and marked conflicting, so I’m keeping this blocked on that PR landing before opening the deletion PR.

Debug info

• Repository: m2lines/Samudra
• Trigger: Delete "static data" #816 (comment)
• Request ID: b5d5e443-e648-4e68-ba54-725a5d971af3
• Accepted: true

[fomo-bot]

#670 has merged, so I completed the cleanup and opened PR #822: #822

The PR deletes the corrector module/tests, removes the Samudra corrector hook, removes static_data_vars / static_data / static_data_for_corrector plumbing, cleans configs/docs, and removes the OM4 preprocessing merge for corrector-only static variables.

Validation passed:

• CUDA_VISIBLE_DEVICES="" uv run pytest -m "not manual and not cuda"
• cd data && uv run --with pytest pytest tests/test_preprocessing.py tests/test_utils.py
• uvx pre-commit run --all-files

Debug info

• Repository: m2lines/Samudra
• Trigger: Delete "static data" #816
• Request ID: 6906525b-17e1-44e4-ab63-c58fec809d4e
• Accepted: true