Skip to content

fix: add descriptive aria labels to interactive controls#1526

Open
srinidhi-2006-bit wants to merge 1 commit into
magic-peach:mainfrom
srinidhi-2006-bit:fix-aria-labels
Open

fix: add descriptive aria labels to interactive controls#1526
srinidhi-2006-bit wants to merge 1 commit into
magic-peach:mainfrom
srinidhi-2006-bit:fix-aria-labels

Conversation

@srinidhi-2006-bit

@srinidhi-2006-bit srinidhi-2006-bit commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Description

Added comprehensive ARIA labels to interactive elements across the application to improve accessibility and screen reader support.

Changes Made

  • Verified and improved ARIA labels in RotateControl.tsx
  • Added descriptive ARIA labels and aria-pressed states in FramingControl.tsx
  • Verified preset selection buttons in PresetSelector.tsx
  • Verified audio controls in AudioSpeedControl.tsx
  • Added ARIA label to the file change button in FileUpload.tsx
  • Improved ARIA labels for download, reset, and sound toggle controls in DownloadResult.tsx

Accessibility Improvements

  • Labels now describe the action performed by each control
  • Improved screen reader experience
  • Added/verified state announcements using aria-pressed
  • Ensured interactive elements have accessible names

Related Issue

Fixes #151

Type of Contribution

  • Bug fix
  • New feature
  • Documentation update
  • Refactor
  • GSSoC contribution

Participant Info

  • GitHub username: srinidhi-2006-bit
  • Contribution level (Beginner/Intermediate/Advanced): Beginner

Screen Recording

Recording / Loom link: not required

Checklist

  • I have read the contribution guidelines
  • My changes follow the project structure
  • I have tested my changes in Chrome, Firefox, and Safari
  • bun run lint passes (no ESLint errors)
  • bunx tsc --noEmit passes (no TypeScript errors)
  • New interactive elements have aria-label / accessible names
  • No console.log statements left in
  • This PR is related to a valid issue
  • Screen recording attached above (required for UI/feature/design changes)

@vercel

vercel Bot commented Jun 3, 2026

Copy link
Copy Markdown

@srinidhi-2006-bit is attempting to deploy a commit to the magic-peach1's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

👋 Thanks for your PR, @srinidhi-2006-bit!

Welcome to Reframe — a browser-based video editor built for everyone 🎬

🟠 GSSoC'26 PR detected — thanks for contributing under GirlScript Summer of Code 2026!

What happens next

  1. 🤖 Automated checks — build & TypeScript typecheck will run automatically
  2. Vercel preview — a preview deployment will be created (requires maintainer authorization for fork PRs)
  3. 👀 Code review — a maintainer will review your changes
  4. 🚀 Merge — once approved, your PR will be merged!

Quick checklist

  • PR title follows Conventional Commits (e.g. feat: add dark mode)
  • Linked the issue this PR closes (e.g. Closes #123)
  • Tested the changes locally (bun run dev)
  • Build passes (bun run build)

Useful links

Happy coding! 🎉

@github-actions github-actions Bot added level:beginner Beginner level - 20 pts type:bug Bug fix type:design UI/UX design type:docs Documentation type:feature New feature type:refactor Code refactor gssoc'26 GirlScript Summer of Code 2026 labels Jun 3, 2026
@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

✅ PR Format Check Passed — @srinidhi-2006-bit

Basic format checks passed. A maintainer will review your code changes.

This does not mean the PR is approved — it just means the format is correct.

@srinidhi-2006-bit

Copy link
Copy Markdown
Contributor Author

Hi @magic-peach
please review my PR

@srinidhi-2006-bit

Copy link
Copy Markdown
Contributor Author

Hi @magic-peach
please review my PR

1 similar comment
@srinidhi-2006-bit

Copy link
Copy Markdown
Contributor Author

Hi @magic-peach
please review my PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc'26 GirlScript Summer of Code 2026 level:beginner Beginner level - 20 pts type:bug Bug fix type:design UI/UX design type:docs Documentation type:feature New feature type:refactor Code refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Accessibility] Add comprehensive ARIA labels to all interactive elements

1 participant