feat: implement Automated Smart-Trim via FFmpeg silencedetect#1553
Open
samalbishnupriya06-stack wants to merge 1 commit into
Open
Conversation
- Add SilenceSegment and SmartTrimStatus types to src/lib/types.ts - Add detectSilence() function to src/lib/ffmpeg.ts using silencedetect filter - Create useSmartTrim hook for silence state management - Create SmartTrimControl component with detect/review/apply UI - Create SilenceTimeline component for visual overlay on video timeline - Wire all components into VideoEditor.tsx Signed-off-by: Samal Bishnupriya <samalbishnupriya.06@gmail.com>
|
@samalbishnupriya06-stack is attempting to deploy a commit to the magic-peach1's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
✅ PR Format Check Passed — @samalbishnupriya06-stackBasic format checks passed. A maintainer will review your code changes. This does not mean the PR is approved — it just means the format is correct. |
Contributor
👋 Thanks for your PR, @samalbishnupriya06-stack!Welcome to Reframe — a browser-based video editor built for everyone 🎬 What happens next
Quick checklist
Useful links
Happy coding! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements Automated Smart-Trim (Phase 1 + Phase 2 + Phase 3 skeleton) as described in issue #<ISSUE_NUMBER>.
Uses the existing FFmpeg WASM pipeline to detect silent segments client-side — no data ever leaves the browser.
Changes
New Files
src/hooks/useSmartTrim.ts— state hook for silence detection, segment toggling, and keep-range computationsrc/components/SmartTrimControl.tsx— UI panel with configurable threshold, segment list, Apply/Reset actionssrc/components/SilenceTimeline.tsx— visual overlay on the video timeline showing silence intervalsModified Files
src/lib/types.ts— addedSilenceSegmentandSmartTrimStatustypessrc/lib/ffmpeg.ts— addeddetectSilence()using FFmpeg'ssilencedetectfiltersrc/components/VideoEditor.tsx— integrateduseSmartTrimhook and new componentsHow It Works
detectSilence()runsffmpeg -af silencedetect=noise=XdB:duration=Ys -f null -on the uploaded filesilence_start/silence_endtimestampsTesting Done
bun run buildpasses)Notes for Reviewers
keepRangesinto the export pipeline for multi-segment concat) is scaffolded inhandleSmartTrimApplybut left as a follow-up, as it requires changes to the FFmpeg filtergraph concat logic. See the TODO comment inVideoEditor.tsx.detectSilencefunction creates its own FFmpeg instance to avoid interfering with the main export pipeline. If the project later moves to a shared instance, this can be refactored.Closes #1146