fix: clamp onboarding tooltip within viewport bounds and fix button accessibility#1557
Open
mallya-m wants to merge 1 commit into
Open
fix: clamp onboarding tooltip within viewport bounds and fix button accessibility#1557mallya-m wants to merge 1 commit into
mallya-m wants to merge 1 commit into
Conversation
|
@mallya-m is attempting to deploy a commit to the magic-peach1's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
✅ PR Format Check Passed — @mallya-mBasic format checks passed. A maintainer will review your code changes. This does not mean the PR is approved — it just means the format is correct. |
Contributor
👋 Thanks for your PR, @mallya-m!Welcome to Reframe — a browser-based video editor built for everyone 🎬 What happens next
Quick checklist
Useful links
Happy coding! 🎉 |
Author
|
@magic-peach ready for review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the onboarding tooltip escaping the viewport by adding
viewport clamping to
getTooltipStyle. Also removes aconsole.errorviolation and adds missingtype="button"and
aria-labelattributes to the Skip and Next buttons.Related issue
Closes #922
Changes made
src/components/OnboardingTour.tsx:getTooltipStyle— tooltip nowstays within viewport bounds on all screen sizes
console.errorfrom catch block per CONTRIBUTING.mdtype="button"to Skip and Next buttonsaria-label="Skip onboarding tour"to Skip buttonHow to test
Checklist
bun run lintpasses (no ESLint errors)bunx tsc --noEmitpasses (no TypeScript errors)aria-label/ accessible namesconsole.logstatements left in