Skip to content

fix: clamp onboarding tooltip within viewport bounds and fix button accessibility#1557

Open
mallya-m wants to merge 1 commit into
magic-peach:mainfrom
mallya-m:fix/issue-922-onboarding-viewport
Open

fix: clamp onboarding tooltip within viewport bounds and fix button accessibility#1557
mallya-m wants to merge 1 commit into
magic-peach:mainfrom
mallya-m:fix/issue-922-onboarding-viewport

Conversation

@mallya-m

@mallya-m mallya-m commented Jun 9, 2026

Copy link
Copy Markdown

What does this PR do?

Fixes the onboarding tooltip escaping the viewport by adding
viewport clamping to getTooltipStyle. Also removes a
console.error violation and adds missing type="button"
and aria-label attributes to the Skip and Next buttons.

Related issue

Closes #922

Changes made

  • src/components/OnboardingTour.tsx:
    • Added viewport clamping to getTooltipStyle — tooltip now
      stays within viewport bounds on all screen sizes
    • Removed console.error from catch block per CONTRIBUTING.md
    • Added type="button" to Skip and Next buttons
    • Added aria-label="Skip onboarding tour" to Skip button

How to test

  1. Open the editor at localhost:3000
  2. Clear site data to trigger onboarding
  3. Resize browser to mobile width (360px)
  4. Confirm tooltip stays within screen bounds on all steps
  5. Confirm Skip and Next buttons work with keyboard

Checklist

  • I have read the contribution guidelines
  • My changes follow the project structure
  • I have tested my changes in Chrome, Firefox, and Safari
  • bun run lint passes (no ESLint errors)
  • bunx tsc --noEmit passes (no TypeScript errors)
  • New interactive elements have aria-label / accessible names
  • No console.log statements left in
  • This PR is related to a valid issue

@vercel

vercel Bot commented Jun 9, 2026

Copy link
Copy Markdown

@mallya-m is attempting to deploy a commit to the magic-peach1's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

✅ PR Format Check Passed — @mallya-m

Basic format checks passed. A maintainer will review your code changes.

This does not mean the PR is approved — it just means the format is correct.

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

👋 Thanks for your PR, @mallya-m!

Welcome to Reframe — a browser-based video editor built for everyone 🎬

What happens next

  1. 🤖 Automated checks — build & TypeScript typecheck will run automatically
  2. Vercel preview — a preview deployment will be created (requires maintainer authorization for fork PRs)
  3. 👀 Code review — a maintainer will review your changes
  4. 🚀 Merge — once approved, your PR will be merged!

Quick checklist

  • PR title follows Conventional Commits (e.g. feat: add dark mode)
  • Linked the issue this PR closes (e.g. Closes #123)
  • Tested the changes locally (bun run dev)
  • Build passes (bun run build)

Useful links

Happy coding! 🎉

@github-actions github-actions Bot added level:beginner Beginner level - 20 pts type:bug Bug fix type:testing Testing labels Jun 9, 2026
@mallya-m

mallya-m commented Jun 9, 2026

Copy link
Copy Markdown
Author

@magic-peach ready for review!
Added viewport clamping to getTooltipStyle so the tooltip can never render outside the screen. Also fixed console.error violation and added missing type="button" and aria-label on the Skip button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

level:beginner Beginner level - 20 pts type:bug Bug fix type:testing Testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] [GSSoC'26] : Onboarding.tsx leaving the viewport.

1 participant