From 3f3e60193e1e304d6d958f85a63fcc0f1aef4061 Mon Sep 17 00:00:00 2001 From: dimitris Date: Wed, 20 May 2026 18:25:39 +0200 Subject: [PATCH] Clear the refresh spinner when an article fails to load --- .../java/com/manuelmaly/hn/ArticleReaderActivity.java | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/app/src/main/java/com/manuelmaly/hn/ArticleReaderActivity.java b/app/src/main/java/com/manuelmaly/hn/ArticleReaderActivity.java index 320aece..0876446 100644 --- a/app/src/main/java/com/manuelmaly/hn/ArticleReaderActivity.java +++ b/app/src/main/java/com/manuelmaly/hn/ArticleReaderActivity.java @@ -7,6 +7,7 @@ import android.os.Bundle; import android.os.Handler; import android.os.Looper; +import android.util.Log; import androidx.appcompat.app.AppCompatActivity; import androidx.core.view.MenuItemCompat; @@ -267,6 +268,8 @@ private void setShowRefreshing(boolean showRefreshing) { } private class HNReaderWebViewClient extends WebViewClient { + private static final String TAG = "HNReaderWebViewClient"; + @Override public void onPageStarted(WebView view, String url, Bitmap favicon) { setShowRefreshing(true); @@ -283,6 +286,13 @@ public void onPageFinished(WebView view, String url) { super.onPageFinished(view, url); } + @Override + public void onReceivedError(WebView view, int errorCode, String description, String failingUrl) { + Log.w(TAG, "Article load failed " + errorCode + ": " + description + " @ " + failingUrl); + setShowRefreshing(false); + mWebViewIsLoading = false; + } + @Override public boolean shouldOverrideUrlLoading( WebView view, String url ) { view.loadUrl( url );