Bind layers tilesets#21
Open
MadEwink wants to merge 2 commits into
Open
Conversation
added 2 commits
April 11, 2022 14:11
Better description Fix linter errors Add comment global tiled Replace CRLF by LF Replace some spaces by tabs Add missing let in for loop
Author
|
Thinking back, even though binding tilesets to tile layers through their names is exactly what I needed, and probably what most people could work with, it would be much better to let users define what their bindings should look like. I'm thinking about using matching rules, probably allowing regular expressions, that could be stored in a file. This change would probably require the creation of a menu with options for more flexibility. As I see it, the tool would have a default behaviour, which matches on exact same name, and it would be possible to deactivate that in the options in order to customize it with a project based configuration file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello !
This extension aims to bind tile layers to tilesets based on their names.
I'm not a javascript dev, and am pretty new to contributing to external projects, so if you have any suggestions on the code, the comments, or on this PR, I will gladly listen.
The linter returned without any prompt on the last commit.
I use Tiled every now and then, and was in need of such a binding, to spare a few clicks, but also to prevent myself from forgetting to change layer before editing, wasting a lot of time doing it on a wring layer.
A few days ago, I decided to take some time to actually try and develop the extension myself, and as a perfect coincidence, stumbled upon this issue mapeditor/tiled#3256, providing me with the extra boost I needed to do it.