Added editablemap property to tiledquick's maploader#4520
Open
UltraDagon wants to merge 24 commits into
Open
Conversation
…id size calculations to use editablemap's size properties in tiledquick's main.qml
…lor property not updating border color
…es or color updates
…nsform node or preferably shader to make it better
… version check to tiledquick's condition to avoid crash when compiling with older qt versions
- Grid in between tiles - Fix file list order - Remove fileTags & overrideTags, relying on defaults
…culation instead of ScreenToTileCoords
* Added copyright headers attributing UltraDagon * Set flags in one call * Fixed emit from MapGridItem::setScale
…loader-editablemap
…/tiled into maploader-editablemap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an editablemap property to maploader, through which you can access the map that maploader currently has. Eventually, this should be able to replace the existing map property and the mapref and mapitem classes, if my understanding is correct.
Added sizeChanged notify signal to make some editablemap q_properties available in tiledquick/qml/main.qml
Moved the Map EditableMap::*map() {} function inside of editablemap's class body to avoid a dll import warning. Let me know if this needs to be reverted and if there is a better method.