Skip to content

MarimoNotebook sidecars should be Kubernetes sidecars #12

@bittrance

Description

@bittrance

Kubernetes now has the notion of sidecars, namely init containers with restart policy. Such containers have their lifecycle coordinated with the main container(s). This makes it a bit confusing that a MarimoNotebook results in a pod with its sidecars as ordinary pod containers. We use sidecar examples like git-sync and openssh-server, which should indeed have their lifecycle coordinated with the marimo container. Assuming we merge #10, we should have sidecars be init containers and possibly rename the sidecars attribute to initContainers. In the latter case, the operator should probably emit warnings when sidecars do not have a restart policy set.

If you think this makes sense, I'll PR accordingly.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions