From 75ac1ce5168439e1c0921592b767fb4435df9ba1 Mon Sep 17 00:00:00 2001 From: Marina Date: Mon, 27 Jul 2020 18:53:47 +0300 Subject: [PATCH 1/3] hm1.3 --- .../java/core/basesyntax/BinaryString.java | 22 ++++++++++++++++++- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/src/main/java/core/basesyntax/BinaryString.java b/src/main/java/core/basesyntax/BinaryString.java index ebec6bf..a249952 100644 --- a/src/main/java/core/basesyntax/BinaryString.java +++ b/src/main/java/core/basesyntax/BinaryString.java @@ -7,6 +7,26 @@ public class BinaryString { * а возвращает String с представлением этого числа в двоичном виде. */ public String toBinaryString(int value) { - return null; + String s = ""; + int a = 0; + int k = value; + while (k / 2 != 0) { + a++; + k = k / 2; + } + a++; + int[] arr = new int[a]; + int i = a - 1; + while (value / 2 != 0) { + arr[i] = value % 2; + value = value / 2; + i--; + } + arr[i] = value; + for (int j = 0; j < arr.length; j++) { + s = s + Integer.toString(arr[j]); + } + + return s; } } From 7ae984005975aba7ad0a3e8adf12acc7a76e3451 Mon Sep 17 00:00:00 2001 From: Marina Date: Tue, 28 Jul 2020 12:19:42 +0300 Subject: [PATCH 2/3] add StringBuilder --- .../java/core/basesyntax/BinaryString.java | 22 ++++--------------- 1 file changed, 4 insertions(+), 18 deletions(-) diff --git a/src/main/java/core/basesyntax/BinaryString.java b/src/main/java/core/basesyntax/BinaryString.java index a249952..f10c880 100644 --- a/src/main/java/core/basesyntax/BinaryString.java +++ b/src/main/java/core/basesyntax/BinaryString.java @@ -7,26 +7,12 @@ public class BinaryString { * а возвращает String с представлением этого числа в двоичном виде. */ public String toBinaryString(int value) { - String s = ""; - int a = 0; - int k = value; - while (k / 2 != 0) { - a++; - k = k / 2; - } - a++; - int[] arr = new int[a]; - int i = a - 1; + StringBuilder str = new StringBuilder(""); while (value / 2 != 0) { - arr[i] = value % 2; + str = str.append(value % 2); value = value / 2; - i--; - } - arr[i] = value; - for (int j = 0; j < arr.length; j++) { - s = s + Integer.toString(arr[j]); } - - return s; + str = str.append(value); + return str.reverse().toString(); } } From a09cb8055e3f088bb45a7a51c0dd7961b5a637b2 Mon Sep 17 00:00:00 2001 From: Marina Date: Tue, 28 Jul 2020 12:49:30 +0300 Subject: [PATCH 3/3] change name --- src/main/java/core/basesyntax/BinaryString.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/main/java/core/basesyntax/BinaryString.java b/src/main/java/core/basesyntax/BinaryString.java index f10c880..6cd929a 100644 --- a/src/main/java/core/basesyntax/BinaryString.java +++ b/src/main/java/core/basesyntax/BinaryString.java @@ -7,12 +7,12 @@ public class BinaryString { * а возвращает String с представлением этого числа в двоичном виде. */ public String toBinaryString(int value) { - StringBuilder str = new StringBuilder(""); + StringBuilder resultstring = new StringBuilder(); while (value / 2 != 0) { - str = str.append(value % 2); + resultstring = resultstring.append(value % 2); value = value / 2; } - str = str.append(value); - return str.reverse().toString(); + resultstring = resultstring.append(value); + return resultstring.reverse().toString(); } }