From e98792f3f6dd82fb4601efaad5c97a8ab92c4c81 Mon Sep 17 00:00:00 2001 From: "m.mikhajlov" Date: Mon, 27 Jul 2020 18:53:06 +0300 Subject: [PATCH 1/3] hw-1.3 --- src/main/java/core/basesyntax/BinaryString.java | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/src/main/java/core/basesyntax/BinaryString.java b/src/main/java/core/basesyntax/BinaryString.java index ebec6bf..9a5dbea 100644 --- a/src/main/java/core/basesyntax/BinaryString.java +++ b/src/main/java/core/basesyntax/BinaryString.java @@ -7,6 +7,15 @@ public class BinaryString { * а возвращает String с представлением этого числа в двоичном виде. */ public String toBinaryString(int value) { - return null; + if (value == 0) { + return "0"; + } + String result = ""; + while (value > 0) { + int a = value % 2; + result = a + result; + value = value / 2; + } + return result; } } From 6e2b52fa91522542403954f6fc711a8e429233a3 Mon Sep 17 00:00:00 2001 From: "m.mikhajlov" Date: Tue, 28 Jul 2020 09:49:23 +0300 Subject: [PATCH 2/3] changed String to StringBuilder --- src/main/java/core/basesyntax/BinaryString.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/main/java/core/basesyntax/BinaryString.java b/src/main/java/core/basesyntax/BinaryString.java index 9a5dbea..e6ce960 100644 --- a/src/main/java/core/basesyntax/BinaryString.java +++ b/src/main/java/core/basesyntax/BinaryString.java @@ -10,12 +10,12 @@ public String toBinaryString(int value) { if (value == 0) { return "0"; } - String result = ""; + StringBuilder result = new StringBuilder(); while (value > 0) { int a = value % 2; - result = a + result; + result.insert(0, a); value = value / 2; } - return result; + return result.toString(); } } From 0b9f5f6f3c48cde11df81e5342d2abddb8c12cc0 Mon Sep 17 00:00:00 2001 From: "m.mikhajlov" Date: Tue, 28 Jul 2020 13:18:19 +0300 Subject: [PATCH 3/3] deleted redundant variable --- src/main/java/core/basesyntax/BinaryString.java | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/main/java/core/basesyntax/BinaryString.java b/src/main/java/core/basesyntax/BinaryString.java index e6ce960..9148a2e 100644 --- a/src/main/java/core/basesyntax/BinaryString.java +++ b/src/main/java/core/basesyntax/BinaryString.java @@ -12,8 +12,7 @@ public String toBinaryString(int value) { } StringBuilder result = new StringBuilder(); while (value > 0) { - int a = value % 2; - result.insert(0, a); + result.insert(0, value % 2); value = value / 2; } return result.toString();