From ea801e7d047477b9968539d003202ac92db710d9 Mon Sep 17 00:00:00 2001 From: vosker Date: Tue, 28 Jul 2020 01:07:04 +0300 Subject: [PATCH 1/4] added solution --- src/main/java/core/basesyntax/BinaryString.java | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/src/main/java/core/basesyntax/BinaryString.java b/src/main/java/core/basesyntax/BinaryString.java index ebec6bf..c8c316e 100644 --- a/src/main/java/core/basesyntax/BinaryString.java +++ b/src/main/java/core/basesyntax/BinaryString.java @@ -7,6 +7,15 @@ public class BinaryString { * а возвращает String с представлением этого числа в двоичном виде. */ public String toBinaryString(int value) { - return null; + if (value == 0) { + return "0"; + } + + StringBuilder str = new StringBuilder(); + while (value > 0) { + str.insert(0, ((value % 2) == 0 ? "0" : "1")); + value = value / 2; + } + return str.toString(); } } From 725fea8f311a9cbe5283abbfee2d484434b72f70 Mon Sep 17 00:00:00 2001 From: vosker Date: Tue, 28 Jul 2020 01:16:44 +0300 Subject: [PATCH 2/4] added informative name of variables --- src/main/java/core/basesyntax/BinaryString.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/main/java/core/basesyntax/BinaryString.java b/src/main/java/core/basesyntax/BinaryString.java index c8c316e..e3af284 100644 --- a/src/main/java/core/basesyntax/BinaryString.java +++ b/src/main/java/core/basesyntax/BinaryString.java @@ -11,11 +11,11 @@ public String toBinaryString(int value) { return "0"; } - StringBuilder str = new StringBuilder(); + StringBuilder binaryString = new StringBuilder(); while (value > 0) { - str.insert(0, ((value % 2) == 0 ? "0" : "1")); + binaryString.insert(0, ((value % 2) == 0 ? "0" : "1")); value = value / 2; } - return str.toString(); + return binaryString.toString(); } } From b5805e306463921b75bbb67c9496bab766f66672 Mon Sep 17 00:00:00 2001 From: vosker Date: Tue, 28 Jul 2020 01:20:55 +0300 Subject: [PATCH 3/4] polished a bit --- src/main/java/core/basesyntax/BinaryString.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/core/basesyntax/BinaryString.java b/src/main/java/core/basesyntax/BinaryString.java index e3af284..de9f7cb 100644 --- a/src/main/java/core/basesyntax/BinaryString.java +++ b/src/main/java/core/basesyntax/BinaryString.java @@ -14,7 +14,7 @@ public String toBinaryString(int value) { StringBuilder binaryString = new StringBuilder(); while (value > 0) { binaryString.insert(0, ((value % 2) == 0 ? "0" : "1")); - value = value / 2; + value /= 2; } return binaryString.toString(); } From add76349ae6de0affcef9efc13ce324855315546 Mon Sep 17 00:00:00 2001 From: vosker Date: Tue, 28 Jul 2020 09:48:56 +0300 Subject: [PATCH 4/4] fixed redundant if-else --- src/main/java/core/basesyntax/BinaryString.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/core/basesyntax/BinaryString.java b/src/main/java/core/basesyntax/BinaryString.java index de9f7cb..07a375b 100644 --- a/src/main/java/core/basesyntax/BinaryString.java +++ b/src/main/java/core/basesyntax/BinaryString.java @@ -13,7 +13,7 @@ public String toBinaryString(int value) { StringBuilder binaryString = new StringBuilder(); while (value > 0) { - binaryString.insert(0, ((value % 2) == 0 ? "0" : "1")); + binaryString.insert(0, value % 2); value /= 2; } return binaryString.toString();