From 7c5b4093fe7ef3e5ee9c1b7ab494419771dba302 Mon Sep 17 00:00:00 2001 From: Victoria-Moiseienko Date: Tue, 28 Jul 2020 06:41:46 +0300 Subject: [PATCH 1/2] add solution --- src/main/java/core/basesyntax/BinaryString.java | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/src/main/java/core/basesyntax/BinaryString.java b/src/main/java/core/basesyntax/BinaryString.java index ebec6bf..1c74a52 100644 --- a/src/main/java/core/basesyntax/BinaryString.java +++ b/src/main/java/core/basesyntax/BinaryString.java @@ -7,6 +7,17 @@ public class BinaryString { * а возвращает String с представлением этого числа в двоичном виде. */ public String toBinaryString(int value) { - return null; + if (value <= 0) { + return "0"; + } + + StringBuilder mirrorString = new StringBuilder(); + + while (value >= 1) { + mirrorString.append(value % 2); + value = value >> 1; + } + + return mirrorString.reverse().toString(); } } From 46f1af65aaf71ea59119c733ae0fd049db22b5ed Mon Sep 17 00:00:00 2001 From: Victoria-Moiseienko Date: Tue, 28 Jul 2020 12:20:31 +0300 Subject: [PATCH 2/2] updated without spaces, return empty result for value < 0 --- src/main/java/core/basesyntax/BinaryString.java | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/main/java/core/basesyntax/BinaryString.java b/src/main/java/core/basesyntax/BinaryString.java index 1c74a52..97fe1f4 100644 --- a/src/main/java/core/basesyntax/BinaryString.java +++ b/src/main/java/core/basesyntax/BinaryString.java @@ -7,17 +7,14 @@ public class BinaryString { * а возвращает String с представлением этого числа в двоичном виде. */ public String toBinaryString(int value) { - if (value <= 0) { + if (value == 0) { return "0"; } - StringBuilder mirrorString = new StringBuilder(); - while (value >= 1) { mirrorString.append(value % 2); value = value >> 1; } - return mirrorString.reverse().toString(); } }