From 4a27ae96c8624c4bc7716cd200688234579d4d5b Mon Sep 17 00:00:00 2001 From: romanHreits Date: Tue, 28 Jul 2020 12:13:57 +0300 Subject: [PATCH 1/3] aded solution binary-string hw-1.3 --- src/main/java/core/basesyntax/BinaryString.java | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/src/main/java/core/basesyntax/BinaryString.java b/src/main/java/core/basesyntax/BinaryString.java index ebec6bf..604f543 100644 --- a/src/main/java/core/basesyntax/BinaryString.java +++ b/src/main/java/core/basesyntax/BinaryString.java @@ -7,6 +7,15 @@ public class BinaryString { * а возвращает String с представлением этого числа в двоичном виде. */ public String toBinaryString(int value) { - return null; + StringBuilder stringBuilder = new StringBuilder(); + if (value > 1) { + while (value > 0) { + int s = !(value % 2 == 0) ? 1 : 0; + value /= 2; + stringBuilder.append(s); + } + return stringBuilder.reverse().toString(); + } + return String.valueOf(value); } -} +} \ No newline at end of file From aeb416e75ddf8f08cee6922f9e2abbe2b5ba5479 Mon Sep 17 00:00:00 2001 From: romanHreits Date: Tue, 28 Jul 2020 12:16:45 +0300 Subject: [PATCH 2/3] corrected checkstyle ERRORS --- src/main/java/core/basesyntax/BinaryString.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/core/basesyntax/BinaryString.java b/src/main/java/core/basesyntax/BinaryString.java index 604f543..c180525 100644 --- a/src/main/java/core/basesyntax/BinaryString.java +++ b/src/main/java/core/basesyntax/BinaryString.java @@ -18,4 +18,4 @@ public String toBinaryString(int value) { } return String.valueOf(value); } -} \ No newline at end of file +} From e6df48f629dc8959d568f3efd306fd81b2f59f28 Mon Sep 17 00:00:00 2001 From: romanHreits Date: Tue, 28 Jul 2020 14:33:58 +0300 Subject: [PATCH 3/3] added final changes to solution --- src/main/java/core/basesyntax/BinaryString.java | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/main/java/core/basesyntax/BinaryString.java b/src/main/java/core/basesyntax/BinaryString.java index c180525..e9cd2e1 100644 --- a/src/main/java/core/basesyntax/BinaryString.java +++ b/src/main/java/core/basesyntax/BinaryString.java @@ -10,9 +10,8 @@ public String toBinaryString(int value) { StringBuilder stringBuilder = new StringBuilder(); if (value > 1) { while (value > 0) { - int s = !(value % 2 == 0) ? 1 : 0; + stringBuilder.append(value % 2); value /= 2; - stringBuilder.append(s); } return stringBuilder.reverse().toString(); }