From baf1a99e1b4e604a2d9da91004e5818e322db908 Mon Sep 17 00:00:00 2001 From: vdsfww Date: Sat, 21 Jun 2025 16:38:56 +0300 Subject: [PATCH] decrease --- logs/app.log | 40 ++++++++++++++++++++++ src/main/java/core/basesyntax/Counter.java | 12 ++++--- src/main/java/core/basesyntax/Main.java | 1 + 3 files changed, 48 insertions(+), 5 deletions(-) create mode 100644 logs/app.log diff --git a/logs/app.log b/logs/app.log new file mode 100644 index 00000000..70ea3ec7 --- /dev/null +++ b/logs/app.log @@ -0,0 +1,40 @@ +INFO core.basesyntax.Counter:19 Before decrementing, Thread # 6, counter value 20 +INFO core.basesyntax.Counter:19 Before decrementing, Thread # 19, counter value 20 +INFO core.basesyntax.Counter:19 Before decrementing, Thread # 16, counter value 20 +INFO core.basesyntax.Counter:19 Before decrementing, Thread # 1, counter value 20 +INFO core.basesyntax.Counter:19 Before decrementing, Thread # 10, counter value 20 +INFO core.basesyntax.Counter:19 Before decrementing, Thread # 17, counter value 20 +INFO core.basesyntax.Counter:19 Before decrementing, Thread # 11, counter value 20 +INFO core.basesyntax.Counter:19 Before decrementing, Thread # 18, counter value 20 +INFO core.basesyntax.Counter:19 Before decrementing, Thread # 20, counter value 20 +INFO core.basesyntax.Counter:22 After decrementing, Thread # 19, counter value 19 +INFO core.basesyntax.Counter:19 Before decrementing, Thread # 9, counter value 20 +INFO core.basesyntax.Counter:19 Before decrementing, Thread # 14, counter value 20 +INFO core.basesyntax.Counter:22 After decrementing, Thread # 18, counter value 13 +INFO core.basesyntax.Counter:19 Before decrementing, Thread # 3, counter value 20 +INFO core.basesyntax.Counter:19 Before decrementing, Thread # 5, counter value 20 +INFO core.basesyntax.Counter:19 Before decrementing, Thread # 4, counter value 20 +INFO core.basesyntax.Counter:22 After decrementing, Thread # 20, counter value 12 +INFO core.basesyntax.Counter:19 Before decrementing, Thread # 13, counter value 20 +INFO core.basesyntax.Counter:22 After decrementing, Thread # 9, counter value 11 +INFO core.basesyntax.Counter:19 Before decrementing, Thread # 7, counter value 20 +INFO core.basesyntax.Counter:19 Before decrementing, Thread # 2, counter value 20 +INFO core.basesyntax.Counter:22 After decrementing, Thread # 3, counter value 9 +INFO core.basesyntax.Counter:22 After decrementing, Thread # 14, counter value 10 +INFO core.basesyntax.Counter:19 Before decrementing, Thread # 8, counter value 20 +INFO core.basesyntax.Counter:19 Before decrementing, Thread # 15, counter value 20 +INFO core.basesyntax.Counter:19 Before decrementing, Thread # 12, counter value 20 +INFO core.basesyntax.Counter:22 After decrementing, Thread # 4, counter value 7 +INFO core.basesyntax.Counter:22 After decrementing, Thread # 5, counter value 8 +INFO core.basesyntax.Counter:22 After decrementing, Thread # 11, counter value 14 +INFO core.basesyntax.Counter:22 After decrementing, Thread # 17, counter value 15 +INFO core.basesyntax.Counter:22 After decrementing, Thread # 8, counter value 5 +INFO core.basesyntax.Counter:22 After decrementing, Thread # 15, counter value 4 +INFO core.basesyntax.Counter:22 After decrementing, Thread # 16, counter value 18 +INFO core.basesyntax.Counter:22 After decrementing, Thread # 10, counter value 16 +INFO core.basesyntax.Counter:22 After decrementing, Thread # 1, counter value 17 +INFO core.basesyntax.Counter:22 After decrementing, Thread # 13, counter value 3 +INFO core.basesyntax.Counter:22 After decrementing, Thread # 12, counter value 1 +INFO core.basesyntax.Counter:22 After decrementing, Thread # 7, counter value 2 +INFO core.basesyntax.Counter:22 After decrementing, Thread # 2, counter value 6 +INFO core.basesyntax.Counter:22 After decrementing, Thread # 6, counter value 0 diff --git a/src/main/java/core/basesyntax/Counter.java b/src/main/java/core/basesyntax/Counter.java index 4af46bd4..2449d38d 100644 --- a/src/main/java/core/basesyntax/Counter.java +++ b/src/main/java/core/basesyntax/Counter.java @@ -1,22 +1,24 @@ package core.basesyntax; +import java.util.concurrent.atomic.AtomicInteger; import org.apache.logging.log4j.LogManager; import org.apache.logging.log4j.Logger; public class Counter { private static final Logger logger = LogManager.getLogger(Counter.class); private static final String MESSAGE = "%20s, Thread # %2s, counter value %2d"; - private int value; + private AtomicInteger value; public Counter(int value) { - this.value = value; + this.value = new AtomicInteger(value); } public void decreaseValue() { + int before = this.value.get(); logger.info(String.format(MESSAGE, - "Before decrementing", Thread.currentThread().getName(), value)); - value--; + "Before decrementing", Thread.currentThread().getName(), before)); + int after = value.decrementAndGet(); logger.info(String.format(MESSAGE, - "After decrementing", Thread.currentThread().getName(), value)); + "After decrementing", Thread.currentThread().getName(), after)); } } diff --git a/src/main/java/core/basesyntax/Main.java b/src/main/java/core/basesyntax/Main.java index 48a2c730..1c9e70ab 100644 --- a/src/main/java/core/basesyntax/Main.java +++ b/src/main/java/core/basesyntax/Main.java @@ -5,6 +5,7 @@ public static void main(String[] args) { Counter counter = new Counter(20); for (int i = 1; i <= 20; i++) { new MyThread(counter, String.valueOf(i)).start(); + } } }