From e0257250802ab377942c54a726edc98af4052a88 Mon Sep 17 00:00:00 2001 From: Timofii Kniahnytskiy Date: Mon, 13 Apr 2026 15:50:01 +0300 Subject: [PATCH 1/4] completed all tasks --- .../java/practice/CandidateValidator.java | 22 +++++++- src/main/java/practice/StreamPractice.java | 50 +++++++++++++++---- 2 files changed, 61 insertions(+), 11 deletions(-) diff --git a/src/main/java/practice/CandidateValidator.java b/src/main/java/practice/CandidateValidator.java index 8d2e56c0e..8739f4a04 100644 --- a/src/main/java/practice/CandidateValidator.java +++ b/src/main/java/practice/CandidateValidator.java @@ -1,5 +1,23 @@ package practice; -public class CandidateValidator { - //write your code here +import model.Candidate; + +import java.util.function.Predicate; + +public class CandidateValidator implements Predicate { + + @Override + public boolean test(Candidate candidate) { + if (candidate.getAge() < 35) return false; + + if (!candidate.isAllowedToVote()) return false; + + if (!"Ukrainian".equals(candidate.getNationality())) return false; + + String[] years = candidate.getPeriodsInUkr().split("-"); + int firstYear = Integer.parseInt(years[0]); + int lastYear = Integer.parseInt(years[1]); + + return (lastYear - firstYear) >= 10; + } } diff --git a/src/main/java/practice/StreamPractice.java b/src/main/java/practice/StreamPractice.java index 57b1ca2e2..50a2faa99 100644 --- a/src/main/java/practice/StreamPractice.java +++ b/src/main/java/practice/StreamPractice.java @@ -1,8 +1,11 @@ package practice; -import java.util.Collections; -import java.util.List; +import java.util.*; +import java.util.stream.Collectors; +import java.util.stream.IntStream; + import model.Candidate; +import model.Cat; import model.Person; public class StreamPractice { @@ -14,7 +17,15 @@ public class StreamPractice { * "Can't get min value from list: < Here is our input 'numbers' >" */ public int findMinEvenNumber(List numbers) { - return 0; + + return numbers.stream() + .flatMap(s -> Arrays.stream(s.split(","))) + .map(Integer::parseInt) + .filter(n -> n % 2 == 0) + .min(Integer::compareTo) + .orElseThrow(() -> new RuntimeException( + "Can't get min value from list: " + numbers + )); } /** @@ -23,9 +34,14 @@ public int findMinEvenNumber(List numbers) { * But before that subtract 1 from each element on an odd position (having the odd index). */ public Double getOddNumsAverage(List numbers) { - return 0D; + return IntStream.range(0, numbers.size()) + .map(i -> i % 2 != 0 + ? numbers.get(i) - 1 + : numbers.get(i)) + .filter(n -> n % 2 != 0) + .average() + .orElseThrow(() -> new NoSuchElementException()); } - /** * Given a List of `Person` instances (having `name`, `age` and `sex` fields), * for example, `Arrays.asList( new Person(«Victor», 16, Sex.MAN), @@ -35,7 +51,10 @@ public Double getOddNumsAverage(List numbers) { * Example: select men who can be recruited to army (from 18 to 27 years old inclusively). */ public List selectMenByAge(List peopleList, int fromAge, int toAge) { - return Collections.emptyList(); + return peopleList.stream() + .filter(p -> p.getSex().equals(Person.Sex.MAN)) + .filter(person -> person.getAge() > fromAge && person.getAge() <= toAge) + .collect(Collectors.toList()); } /** @@ -50,7 +69,10 @@ public List selectMenByAge(List peopleList, int fromAge, int toA */ public List getWorkablePeople(int fromAge, int femaleToAge, int maleToAge, List peopleList) { - return Collections.emptyList(); + return peopleList.stream() + .filter(p -> (p.getSex().equals(Person.Sex.WOMAN) && p.getAge() >= fromAge && p.getAge() <= femaleToAge) + || (p.getSex().equals(Person.Sex.MAN) && p.getAge() >= fromAge && p.getAge() <= maleToAge)) + .collect(Collectors.toList()); } /** @@ -59,7 +81,12 @@ public List getWorkablePeople(int fromAge, int femaleToAge, * return the names of all cats whose owners are women from `femaleAge` years old inclusively. */ public List getCatsNames(List peopleList, int femaleAge) { - return Collections.emptyList(); + return peopleList.stream() + .filter(person -> person.getSex().equals(Person.Sex.WOMAN) && person.getAge() >= femaleAge) + .map(Person::getCats) + .flatMap(Collection::stream) + .map(Cat::getName) + .collect(Collectors.toList()); } /** @@ -75,6 +102,11 @@ public List getCatsNames(List peopleList, int femaleAge) { * parametrized with Candidate in CandidateValidator. */ public List validateCandidates(List candidates) { - return Collections.emptyList(); + + return candidates.stream() + .filter(new CandidateValidator()) + .map(Candidate::getName) + .sorted() + .toList(); } } From ff9be51051bf8a27dd7ff4b64ccdb5802c686c54 Mon Sep 17 00:00:00 2001 From: Timofii Kniahnytskiy Date: Mon, 13 Apr 2026 15:59:13 +0300 Subject: [PATCH 2/4] check with mvn --- .../java/practice/CandidateValidator.java | 15 ++++++++++----- src/main/java/practice/StreamPractice.java | 19 +++++++++++++------ 2 files changed, 23 insertions(+), 11 deletions(-) diff --git a/src/main/java/practice/CandidateValidator.java b/src/main/java/practice/CandidateValidator.java index 8739f4a04..9a35bcd78 100644 --- a/src/main/java/practice/CandidateValidator.java +++ b/src/main/java/practice/CandidateValidator.java @@ -1,18 +1,23 @@ package practice; -import model.Candidate; - import java.util.function.Predicate; +import model.Candidate; public class CandidateValidator implements Predicate { @Override public boolean test(Candidate candidate) { - if (candidate.getAge() < 35) return false; + if (candidate.getAge() < 35) { + return false; + } - if (!candidate.isAllowedToVote()) return false; + if (!candidate.isAllowedToVote()) { + return false; + } - if (!"Ukrainian".equals(candidate.getNationality())) return false; + if (!"Ukrainian".equals(candidate.getNationality())) { + return false; + } String[] years = candidate.getPeriodsInUkr().split("-"); int firstYear = Integer.parseInt(years[0]); diff --git a/src/main/java/practice/StreamPractice.java b/src/main/java/practice/StreamPractice.java index 50a2faa99..93f694679 100644 --- a/src/main/java/practice/StreamPractice.java +++ b/src/main/java/practice/StreamPractice.java @@ -1,9 +1,11 @@ package practice; -import java.util.*; +import java.util.Arrays; +import java.util.Collection; +import java.util.List; +import java.util.NoSuchElementException; import java.util.stream.Collectors; import java.util.stream.IntStream; - import model.Candidate; import model.Cat; import model.Person; @@ -40,7 +42,7 @@ public Double getOddNumsAverage(List numbers) { : numbers.get(i)) .filter(n -> n % 2 != 0) .average() - .orElseThrow(() -> new NoSuchElementException()); + .orElseThrow(NoSuchElementException::new); } /** * Given a List of `Person` instances (having `name`, `age` and `sex` fields), @@ -50,6 +52,7 @@ public Double getOddNumsAverage(List numbers) { *

* Example: select men who can be recruited to army (from 18 to 27 years old inclusively). */ + public List selectMenByAge(List peopleList, int fromAge, int toAge) { return peopleList.stream() .filter(p -> p.getSex().equals(Person.Sex.MAN)) @@ -70,8 +73,11 @@ public List selectMenByAge(List peopleList, int fromAge, int toA public List getWorkablePeople(int fromAge, int femaleToAge, int maleToAge, List peopleList) { return peopleList.stream() - .filter(p -> (p.getSex().equals(Person.Sex.WOMAN) && p.getAge() >= fromAge && p.getAge() <= femaleToAge) - || (p.getSex().equals(Person.Sex.MAN) && p.getAge() >= fromAge && p.getAge() <= maleToAge)) + .filter(p -> (p.getSex().equals(Person.Sex.WOMAN) + && p.getAge() >= fromAge + && p.getAge() <= femaleToAge) + || (p.getSex().equals(Person.Sex.MAN) + && p.getAge() >= fromAge && p.getAge() <= maleToAge)) .collect(Collectors.toList()); } @@ -82,7 +88,8 @@ public List getWorkablePeople(int fromAge, int femaleToAge, */ public List getCatsNames(List peopleList, int femaleAge) { return peopleList.stream() - .filter(person -> person.getSex().equals(Person.Sex.WOMAN) && person.getAge() >= femaleAge) + .filter(person -> person.getSex().equals(Person.Sex.WOMAN) + && person.getAge() >= femaleAge) .map(Person::getCats) .flatMap(Collection::stream) .map(Cat::getName) From ae307a714e011f4ee396731c6ba8cfce81cb2e62 Mon Sep 17 00:00:00 2001 From: Timofii Kniahnytskiy Date: Mon, 13 Apr 2026 17:57:05 +0300 Subject: [PATCH 3/4] little refactoring --- src/main/java/practice/StreamPractice.java | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/main/java/practice/StreamPractice.java b/src/main/java/practice/StreamPractice.java index 93f694679..aa1a9b083 100644 --- a/src/main/java/practice/StreamPractice.java +++ b/src/main/java/practice/StreamPractice.java @@ -21,7 +21,7 @@ public class StreamPractice { public int findMinEvenNumber(List numbers) { return numbers.stream() - .flatMap(s -> Arrays.stream(s.split(","))) + .flatMap(s -> Arrays.stream(s.trim().split(","))) .map(Integer::parseInt) .filter(n -> n % 2 == 0) .min(Integer::compareTo) @@ -55,8 +55,8 @@ public Double getOddNumsAverage(List numbers) { public List selectMenByAge(List peopleList, int fromAge, int toAge) { return peopleList.stream() - .filter(p -> p.getSex().equals(Person.Sex.MAN)) - .filter(person -> person.getAge() > fromAge && person.getAge() <= toAge) + .filter(p -> p.getSex() == Person.Sex.MAN) + .filter(person -> person.getAge() >= fromAge && person.getAge() <= toAge) .collect(Collectors.toList()); } @@ -73,10 +73,10 @@ public List selectMenByAge(List peopleList, int fromAge, int toA public List getWorkablePeople(int fromAge, int femaleToAge, int maleToAge, List peopleList) { return peopleList.stream() - .filter(p -> (p.getSex().equals(Person.Sex.WOMAN) + .filter(p -> (p.getSex() == Person.Sex.WOMAN && p.getAge() >= fromAge && p.getAge() <= femaleToAge) - || (p.getSex().equals(Person.Sex.MAN) + || (p.getSex() == Person.Sex.MAN && p.getAge() >= fromAge && p.getAge() <= maleToAge)) .collect(Collectors.toList()); } @@ -88,7 +88,7 @@ public List getWorkablePeople(int fromAge, int femaleToAge, */ public List getCatsNames(List peopleList, int femaleAge) { return peopleList.stream() - .filter(person -> person.getSex().equals(Person.Sex.WOMAN) + .filter(person -> person.getSex() == Person.Sex.WOMAN && person.getAge() >= femaleAge) .map(Person::getCats) .flatMap(Collection::stream) From c1e921148b02c713139efdf1ec5622c6a68ad279 Mon Sep 17 00:00:00 2001 From: Timofii Kniahnytskiy Date: Mon, 13 Apr 2026 18:07:37 +0300 Subject: [PATCH 4/4] little refactoring 2 --- src/main/java/practice/CandidateValidator.java | 9 ++++++--- src/main/java/practice/StreamPractice.java | 3 ++- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/src/main/java/practice/CandidateValidator.java b/src/main/java/practice/CandidateValidator.java index 9a35bcd78..aee61e4a0 100644 --- a/src/main/java/practice/CandidateValidator.java +++ b/src/main/java/practice/CandidateValidator.java @@ -4,10 +4,13 @@ import model.Candidate; public class CandidateValidator implements Predicate { + private static final String NATIONALITY = "Ukrainian"; + private static final int REQUIRED_YEARS_IN_UKRAINE = 10; + private static final int MIN_AGE = 35; @Override public boolean test(Candidate candidate) { - if (candidate.getAge() < 35) { + if (candidate.getAge() < MIN_AGE) { return false; } @@ -15,7 +18,7 @@ public boolean test(Candidate candidate) { return false; } - if (!"Ukrainian".equals(candidate.getNationality())) { + if (!NATIONALITY.equals(candidate.getNationality())) { return false; } @@ -23,6 +26,6 @@ public boolean test(Candidate candidate) { int firstYear = Integer.parseInt(years[0]); int lastYear = Integer.parseInt(years[1]); - return (lastYear - firstYear) >= 10; + return (lastYear - firstYear) >= REQUIRED_YEARS_IN_UKRAINE; } } diff --git a/src/main/java/practice/StreamPractice.java b/src/main/java/practice/StreamPractice.java index aa1a9b083..8d8b7b40a 100644 --- a/src/main/java/practice/StreamPractice.java +++ b/src/main/java/practice/StreamPractice.java @@ -21,7 +21,8 @@ public class StreamPractice { public int findMinEvenNumber(List numbers) { return numbers.stream() - .flatMap(s -> Arrays.stream(s.trim().split(","))) + .flatMap(s -> Arrays.stream(s.split(","))) + .map(String::trim) .map(Integer::parseInt) .filter(n -> n % 2 == 0) .min(Integer::compareTo)