From 2ae7c16096ec54bc72cfe72e4998f848d036be1d Mon Sep 17 00:00:00 2001 From: shpinat974 Date: Sun, 3 May 2026 12:07:51 +0300 Subject: [PATCH 1/2] implemented helpers for elections --- .../java/practice/CandidateValidator.java | 15 +++++- src/main/java/practice/StreamPractice.java | 49 ++++++++++++++++--- 2 files changed, 55 insertions(+), 9 deletions(-) diff --git a/src/main/java/practice/CandidateValidator.java b/src/main/java/practice/CandidateValidator.java index 8d2e56c0e..a9c211acc 100644 --- a/src/main/java/practice/CandidateValidator.java +++ b/src/main/java/practice/CandidateValidator.java @@ -1,5 +1,16 @@ package practice; -public class CandidateValidator { - //write your code here +import java.util.function.Predicate; +import model.Candidate; + +public class CandidateValidator implements Predicate { + @Override + public boolean test(Candidate c) { + int yearFrom = Integer.parseInt(c.getPeriodsInUkr().split("-")[0]); + int yearTo = Integer.parseInt(c.getPeriodsInUkr().split("-")[1]); + int yearsDiff = yearTo - yearFrom; + + return c.getAge() >= 35 && c.isAllowedToVote() && c.getNationality().equals("Ukrainian") + && yearsDiff >= 10; + } } diff --git a/src/main/java/practice/StreamPractice.java b/src/main/java/practice/StreamPractice.java index 57b1ca2e2..397a03cef 100644 --- a/src/main/java/practice/StreamPractice.java +++ b/src/main/java/practice/StreamPractice.java @@ -1,8 +1,12 @@ package practice; -import java.util.Collections; +import java.util.Arrays; +import java.util.Comparator; import java.util.List; +import java.util.NoSuchElementException; +import java.util.stream.IntStream; import model.Candidate; +import model.Cat; import model.Person; public class StreamPractice { @@ -14,7 +18,13 @@ public class StreamPractice { * "Can't get min value from list: < Here is our input 'numbers' >" */ public int findMinEvenNumber(List numbers) { - return 0; + return numbers.stream() + .flatMapToInt(s -> Arrays.stream(s.split(",")) + .mapToInt(Integer::parseInt)) + .filter(i -> i % 2 == 0) + .min() + .orElseThrow(() -> new RuntimeException( + "Can't get min value from list: " + numbers)); } /** @@ -23,7 +33,11 @@ public int findMinEvenNumber(List numbers) { * But before that subtract 1 from each element on an odd position (having the odd index). */ public Double getOddNumsAverage(List numbers) { - return 0D; + return IntStream.range(0, numbers.size()) + .map(i -> i % 2 != 0 ? numbers.get(i) - 1 : numbers.get(i)) + .filter(n -> n % 2 != 0) + .average() + .orElseThrow(NoSuchElementException::new); } /** @@ -35,7 +49,13 @@ public Double getOddNumsAverage(List numbers) { * Example: select men who can be recruited to army (from 18 to 27 years old inclusively). */ public List selectMenByAge(List peopleList, int fromAge, int toAge) { - return Collections.emptyList(); + return peopleList.stream() + .filter(p -> { + return p.getSex() == Person.Sex.MAN + && p.getAge() >= fromAge + && p.getAge() <= toAge; + }) + .toList(); } /** @@ -50,7 +70,12 @@ public List selectMenByAge(List peopleList, int fromAge, int toA */ public List getWorkablePeople(int fromAge, int femaleToAge, int maleToAge, List peopleList) { - return Collections.emptyList(); + return peopleList.stream() + .filter(p -> { + int toAge = p.getSex() == Person.Sex.MAN ? maleToAge : femaleToAge; + return p.getAge() >= fromAge && p.getAge() <= toAge; + }) + .toList(); } /** @@ -59,7 +84,13 @@ public List getWorkablePeople(int fromAge, int femaleToAge, * return the names of all cats whose owners are women from `femaleAge` years old inclusively. */ public List getCatsNames(List peopleList, int femaleAge) { - return Collections.emptyList(); + return peopleList.stream() + .filter(p -> { + return p.getSex() == Person.Sex.WOMAN && p.getAge() >= femaleAge; + }) + .flatMap(p -> p.getCats().stream()) + .map(Cat::getName) + .toList(); } /** @@ -75,6 +106,10 @@ public List getCatsNames(List peopleList, int femaleAge) { * parametrized with Candidate in CandidateValidator. */ public List validateCandidates(List candidates) { - return Collections.emptyList(); + return candidates.stream() + .filter(c -> new CandidateValidator().test(c)) + .sorted(Comparator.comparing(Candidate::getName)) + .map(Candidate::getName) + .toList(); } } From c245aac2ec89026ebf5301c09f0e7a69e3c8b8be Mon Sep 17 00:00:00 2001 From: shpinat974 Date: Sun, 3 May 2026 12:16:29 +0300 Subject: [PATCH 2/2] fixed PR comments --- src/main/java/practice/CandidateValidator.java | 10 ++++++++-- src/main/java/practice/StreamPractice.java | 6 +++--- 2 files changed, 11 insertions(+), 5 deletions(-) diff --git a/src/main/java/practice/CandidateValidator.java b/src/main/java/practice/CandidateValidator.java index a9c211acc..0d52de1b4 100644 --- a/src/main/java/practice/CandidateValidator.java +++ b/src/main/java/practice/CandidateValidator.java @@ -4,13 +4,19 @@ import model.Candidate; public class CandidateValidator implements Predicate { + private static final int MIN_AGE = 35; + private static final String NATIONALITY = "Ukrainian"; + private static final int MIN_YEARS_IN_UKR = 10; + @Override public boolean test(Candidate c) { int yearFrom = Integer.parseInt(c.getPeriodsInUkr().split("-")[0]); int yearTo = Integer.parseInt(c.getPeriodsInUkr().split("-")[1]); int yearsDiff = yearTo - yearFrom; - return c.getAge() >= 35 && c.isAllowedToVote() && c.getNationality().equals("Ukrainian") - && yearsDiff >= 10; + return c.getAge() >= MIN_AGE + && c.isAllowedToVote() + && c.getNationality().equals(NATIONALITY) + && yearsDiff >= MIN_YEARS_IN_UKR; } } diff --git a/src/main/java/practice/StreamPractice.java b/src/main/java/practice/StreamPractice.java index 397a03cef..0c63e2cb4 100644 --- a/src/main/java/practice/StreamPractice.java +++ b/src/main/java/practice/StreamPractice.java @@ -51,7 +51,7 @@ public Double getOddNumsAverage(List numbers) { public List selectMenByAge(List peopleList, int fromAge, int toAge) { return peopleList.stream() .filter(p -> { - return p.getSex() == Person.Sex.MAN + return p.getSex().equals(Person.Sex.MAN) && p.getAge() >= fromAge && p.getAge() <= toAge; }) @@ -72,7 +72,7 @@ public List getWorkablePeople(int fromAge, int femaleToAge, int maleToAge, List peopleList) { return peopleList.stream() .filter(p -> { - int toAge = p.getSex() == Person.Sex.MAN ? maleToAge : femaleToAge; + int toAge = p.getSex().equals(Person.Sex.MAN) ? maleToAge : femaleToAge; return p.getAge() >= fromAge && p.getAge() <= toAge; }) .toList(); @@ -86,7 +86,7 @@ public List getWorkablePeople(int fromAge, int femaleToAge, public List getCatsNames(List peopleList, int femaleAge) { return peopleList.stream() .filter(p -> { - return p.getSex() == Person.Sex.WOMAN && p.getAge() >= femaleAge; + return p.getSex().equals(Person.Sex.WOMAN) && p.getAge() >= femaleAge; }) .flatMap(p -> p.getCats().stream()) .map(Cat::getName)