From 471ff833be814ea41581e185762bd328251fa5ae Mon Sep 17 00:00:00 2001 From: darina_melnyk Date: Tue, 12 May 2026 23:14:56 +0300 Subject: [PATCH 1/5] Finish README task --- .../java/practice/CandidateValidator.java | 24 +++++++++++- src/main/java/practice/StreamPractice.java | 39 ++++++++++++++++--- 2 files changed, 55 insertions(+), 8 deletions(-) diff --git a/src/main/java/practice/CandidateValidator.java b/src/main/java/practice/CandidateValidator.java index 8d2e56c0e..1d79f7505 100644 --- a/src/main/java/practice/CandidateValidator.java +++ b/src/main/java/practice/CandidateValidator.java @@ -1,5 +1,25 @@ package practice; -public class CandidateValidator { - //write your code here +import java.util.function.Predicate; +import model.Candidate; + +public class CandidateValidator implements Predicate{ + + @Override + public boolean test(Candidate c) { + if (c.getAge() < 35) { + return false; + } + if (!c.isAllowedToVote()) { + return false; + } + if (!c.getNationality().equals("Ukrainian")) { + return false; + } + String[] years = c.getPeriodsInUkr().split("-"); + if (Integer.parseInt(years[1]) - Integer.parseInt(years[0]) < 10) { + return false; + } + return true; + } } diff --git a/src/main/java/practice/StreamPractice.java b/src/main/java/practice/StreamPractice.java index 57b1ca2e2..25525298b 100644 --- a/src/main/java/practice/StreamPractice.java +++ b/src/main/java/practice/StreamPractice.java @@ -2,7 +2,10 @@ import java.util.Collections; import java.util.List; +import java.util.stream.Collectors; +import java.util.stream.IntStream; import model.Candidate; +import model.Cat; import model.Person; public class StreamPractice { @@ -14,7 +17,11 @@ public class StreamPractice { * "Can't get min value from list: < Here is our input 'numbers' >" */ public int findMinEvenNumber(List numbers) { - return 0; + return numbers.stream() + .flatMapToInt(null) + .filter(n -> n % 2 != 0) + .min() + .getAsInt(); } /** @@ -23,7 +30,12 @@ public int findMinEvenNumber(List numbers) { * But before that subtract 1 from each element on an odd position (having the odd index). */ public Double getOddNumsAverage(List numbers) { - return 0D; + return IntStream.range(0, numbers.size()) + .filter(i -> i % 2 != 0) + .map(i -> numbers.get(i)) + .filter(n -> n % 2 != 0) + .average() + .orElseThrow(); } /** @@ -35,7 +47,10 @@ public Double getOddNumsAverage(List numbers) { * Example: select men who can be recruited to army (from 18 to 27 years old inclusively). */ public List selectMenByAge(List peopleList, int fromAge, int toAge) { - return Collections.emptyList(); + return peopleList.stream() + .filter(p -> p.getAge() >= fromAge && p.getAge() <= toAge + && p.getSex() == Person.Sex.MAN) + .collect(Collectors.toList()); } /** @@ -50,7 +65,10 @@ public List selectMenByAge(List peopleList, int fromAge, int toA */ public List getWorkablePeople(int fromAge, int femaleToAge, int maleToAge, List peopleList) { - return Collections.emptyList(); + return peopleList.stream() + .filter(p -> p.getSex() == Person.Sex.MAN ? + (p.getAge() >= fromAge && p.getAge() <= maleToAge) : p.getAge() <= femaleToAge) + .collect(Collectors.toList()); } /** @@ -59,7 +77,11 @@ public List getWorkablePeople(int fromAge, int femaleToAge, * return the names of all cats whose owners are women from `femaleAge` years old inclusively. */ public List getCatsNames(List peopleList, int femaleAge) { - return Collections.emptyList(); + return peopleList.stream() + .filter(p -> p.getSex() == Person.Sex.WOMAN && p.getAge() >= femaleAge) + .flatMap(p -> p.getCats().stream()) + .map(Cat::getName) + .collect(Collectors.toList()); } /** @@ -75,6 +97,11 @@ public List getCatsNames(List peopleList, int femaleAge) { * parametrized with Candidate in CandidateValidator. */ public List validateCandidates(List candidates) { - return Collections.emptyList(); + CandidateValidator validator = new CandidateValidator(); + return candidates.stream() + .filter(c -> validator.test(c)) + .map(c -> c.getName()) + .sorted() + .toList(); } } From 48213ba66c28b76f31d44c41e3765ac80b301699 Mon Sep 17 00:00:00 2001 From: darina_melnyk Date: Wed, 13 May 2026 14:11:44 +0300 Subject: [PATCH 2/5] Fix review comments --- .../java/practice/CandidateValidator.java | 11 +++++--- src/main/java/practice/StreamPractice.java | 27 ++++++++++--------- 2 files changed, 22 insertions(+), 16 deletions(-) diff --git a/src/main/java/practice/CandidateValidator.java b/src/main/java/practice/CandidateValidator.java index 1d79f7505..51a0b77b7 100644 --- a/src/main/java/practice/CandidateValidator.java +++ b/src/main/java/practice/CandidateValidator.java @@ -3,21 +3,24 @@ import java.util.function.Predicate; import model.Candidate; -public class CandidateValidator implements Predicate{ +public class CandidateValidator implements Predicate { + private static final int MIN_AGE = 35; + private static final int MIN_YEARS_IN_UKRAINE = 10; + private static final String UKRAINIAN_NATIONALITY = "Ukrainian"; @Override public boolean test(Candidate c) { - if (c.getAge() < 35) { + if (c.getAge() < MIN_AGE) { return false; } if (!c.isAllowedToVote()) { return false; } - if (!c.getNationality().equals("Ukrainian")) { + if (!c.getNationality().equals(UKRAINIAN_NATIONALITY)) { return false; } String[] years = c.getPeriodsInUkr().split("-"); - if (Integer.parseInt(years[1]) - Integer.parseInt(years[0]) < 10) { + if (Integer.parseInt(years[1]) - Integer.parseInt(years[0]) < MIN_YEARS_IN_UKRAINE) { return false; } return true; diff --git a/src/main/java/practice/StreamPractice.java b/src/main/java/practice/StreamPractice.java index 25525298b..3a196f9df 100644 --- a/src/main/java/practice/StreamPractice.java +++ b/src/main/java/practice/StreamPractice.java @@ -1,12 +1,13 @@ package practice; -import java.util.Collections; +import java.util.Arrays; import java.util.List; import java.util.stream.Collectors; import java.util.stream.IntStream; import model.Candidate; import model.Cat; import model.Person; +import model.Person.Sex; public class StreamPractice { /** @@ -18,10 +19,12 @@ public class StreamPractice { */ public int findMinEvenNumber(List numbers) { return numbers.stream() - .flatMapToInt(null) - .filter(n -> n % 2 != 0) + .flatMap(s -> Arrays.stream(s.split(","))) + .mapToInt(Integer::parseInt) + .filter(n -> n % 2 == 0) .min() - .getAsInt(); + .orElseThrow(() -> new IllegalArgumentException( + "Can't get min value from list: " + numbers)); } /** @@ -31,8 +34,7 @@ public int findMinEvenNumber(List numbers) { */ public Double getOddNumsAverage(List numbers) { return IntStream.range(0, numbers.size()) - .filter(i -> i % 2 != 0) - .map(i -> numbers.get(i)) + .map(i -> i % 2 != 0 ? numbers.get(i) - 1 : numbers.get(i)) .filter(n -> n % 2 != 0) .average() .orElseThrow(); @@ -49,8 +51,8 @@ public Double getOddNumsAverage(List numbers) { public List selectMenByAge(List peopleList, int fromAge, int toAge) { return peopleList.stream() .filter(p -> p.getAge() >= fromAge && p.getAge() <= toAge - && p.getSex() == Person.Sex.MAN) - .collect(Collectors.toList()); + && p.getSex() == Sex.MAN) + .toList(); } /** @@ -66,8 +68,9 @@ public List selectMenByAge(List peopleList, int fromAge, int toA public List getWorkablePeople(int fromAge, int femaleToAge, int maleToAge, List peopleList) { return peopleList.stream() - .filter(p -> p.getSex() == Person.Sex.MAN ? - (p.getAge() >= fromAge && p.getAge() <= maleToAge) : p.getAge() <= femaleToAge) + .filter(p -> p.getSex() == Person.Sex.MAN + ? (p.getAge() >= fromAge && p.getAge() <= maleToAge) + : p.getAge() >= fromAge && p.getAge() <= femaleToAge) .collect(Collectors.toList()); } @@ -78,10 +81,10 @@ public List getWorkablePeople(int fromAge, int femaleToAge, */ public List getCatsNames(List peopleList, int femaleAge) { return peopleList.stream() - .filter(p -> p.getSex() == Person.Sex.WOMAN && p.getAge() >= femaleAge) + .filter(p -> p.getSex() == Sex.WOMAN && p.getAge() >= femaleAge) .flatMap(p -> p.getCats().stream()) .map(Cat::getName) - .collect(Collectors.toList()); + .toList(); } /** From 80c1b183680fa83e13175f3714bf779d595a8ce5 Mon Sep 17 00:00:00 2001 From: darina_melnyk Date: Wed, 13 May 2026 14:19:00 +0300 Subject: [PATCH 3/5] Fix review comments --- src/main/java/practice/StreamPractice.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/main/java/practice/StreamPractice.java b/src/main/java/practice/StreamPractice.java index 3a196f9df..7317833b7 100644 --- a/src/main/java/practice/StreamPractice.java +++ b/src/main/java/practice/StreamPractice.java @@ -23,7 +23,7 @@ public int findMinEvenNumber(List numbers) { .mapToInt(Integer::parseInt) .filter(n -> n % 2 == 0) .min() - .orElseThrow(() -> new IllegalArgumentException( + .orElseThrow(() -> new RuntimeException( "Can't get min value from list: " + numbers)); } @@ -51,7 +51,7 @@ public Double getOddNumsAverage(List numbers) { public List selectMenByAge(List peopleList, int fromAge, int toAge) { return peopleList.stream() .filter(p -> p.getAge() >= fromAge && p.getAge() <= toAge - && p.getSex() == Sex.MAN) + && p.getSex().equals("MAN")) .toList(); } @@ -68,7 +68,7 @@ public List selectMenByAge(List peopleList, int fromAge, int toA public List getWorkablePeople(int fromAge, int femaleToAge, int maleToAge, List peopleList) { return peopleList.stream() - .filter(p -> p.getSex() == Person.Sex.MAN + .filter(p -> p.getSex().equals("MAN") ? (p.getAge() >= fromAge && p.getAge() <= maleToAge) : p.getAge() >= fromAge && p.getAge() <= femaleToAge) .collect(Collectors.toList()); @@ -81,7 +81,7 @@ public List getWorkablePeople(int fromAge, int femaleToAge, */ public List getCatsNames(List peopleList, int femaleAge) { return peopleList.stream() - .filter(p -> p.getSex() == Sex.WOMAN && p.getAge() >= femaleAge) + .filter(p -> p.getSex().equals("WOMAN") && p.getAge() >= femaleAge) .flatMap(p -> p.getCats().stream()) .map(Cat::getName) .toList(); From e975619821a76b2603d60e3b1be6aefd81aa9636 Mon Sep 17 00:00:00 2001 From: darina_melnyk Date: Wed, 13 May 2026 14:21:58 +0300 Subject: [PATCH 4/5] Fix review comments --- src/main/java/practice/StreamPractice.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/main/java/practice/StreamPractice.java b/src/main/java/practice/StreamPractice.java index 7317833b7..4138985b7 100644 --- a/src/main/java/practice/StreamPractice.java +++ b/src/main/java/practice/StreamPractice.java @@ -51,7 +51,7 @@ public Double getOddNumsAverage(List numbers) { public List selectMenByAge(List peopleList, int fromAge, int toAge) { return peopleList.stream() .filter(p -> p.getAge() >= fromAge && p.getAge() <= toAge - && p.getSex().equals("MAN")) + && p.getSex().equals(Sex.MAN)) .toList(); } @@ -68,7 +68,7 @@ public List selectMenByAge(List peopleList, int fromAge, int toA public List getWorkablePeople(int fromAge, int femaleToAge, int maleToAge, List peopleList) { return peopleList.stream() - .filter(p -> p.getSex().equals("MAN") + .filter(p -> p.getSex().equals(Sex.MAN) ? (p.getAge() >= fromAge && p.getAge() <= maleToAge) : p.getAge() >= fromAge && p.getAge() <= femaleToAge) .collect(Collectors.toList()); @@ -81,7 +81,7 @@ public List getWorkablePeople(int fromAge, int femaleToAge, */ public List getCatsNames(List peopleList, int femaleAge) { return peopleList.stream() - .filter(p -> p.getSex().equals("WOMAN") && p.getAge() >= femaleAge) + .filter(p -> p.getSex().equals(Sex.WOMAN) && p.getAge() >= femaleAge) .flatMap(p -> p.getCats().stream()) .map(Cat::getName) .toList(); From 5fd4b52c9b645f8fbcc54d200a1b47b1c496fc26 Mon Sep 17 00:00:00 2001 From: darina_melnyk Date: Wed, 13 May 2026 21:40:15 +0300 Subject: [PATCH 5/5] Fix review comments --- .../java/practice/CandidateValidator.java | 23 +++++++------------ src/main/java/practice/StreamPractice.java | 7 +++--- 2 files changed, 11 insertions(+), 19 deletions(-) diff --git a/src/main/java/practice/CandidateValidator.java b/src/main/java/practice/CandidateValidator.java index 51a0b77b7..7806a88ff 100644 --- a/src/main/java/practice/CandidateValidator.java +++ b/src/main/java/practice/CandidateValidator.java @@ -9,20 +9,13 @@ public class CandidateValidator implements Predicate { private static final String UKRAINIAN_NATIONALITY = "Ukrainian"; @Override - public boolean test(Candidate c) { - if (c.getAge() < MIN_AGE) { - return false; - } - if (!c.isAllowedToVote()) { - return false; - } - if (!c.getNationality().equals(UKRAINIAN_NATIONALITY)) { - return false; - } - String[] years = c.getPeriodsInUkr().split("-"); - if (Integer.parseInt(years[1]) - Integer.parseInt(years[0]) < MIN_YEARS_IN_UKRAINE) { - return false; - } - return true; + public boolean test(Candidate candidate) { + String[] years = candidate.getPeriodsInUkr().split("-"); + return candidate.getAge() < MIN_AGE ? false + : !candidate.isAllowedToVote() ? false + : !candidate.getNationality().equals(UKRAINIAN_NATIONALITY) ? false + : Integer.parseInt(years[1]) - Integer.parseInt(years[0]) + < MIN_YEARS_IN_UKRAINE ? false + : true; } } diff --git a/src/main/java/practice/StreamPractice.java b/src/main/java/practice/StreamPractice.java index 4138985b7..c0183b6e1 100644 --- a/src/main/java/practice/StreamPractice.java +++ b/src/main/java/practice/StreamPractice.java @@ -2,7 +2,6 @@ import java.util.Arrays; import java.util.List; -import java.util.stream.Collectors; import java.util.stream.IntStream; import model.Candidate; import model.Cat; @@ -71,7 +70,7 @@ public List getWorkablePeople(int fromAge, int femaleToAge, .filter(p -> p.getSex().equals(Sex.MAN) ? (p.getAge() >= fromAge && p.getAge() <= maleToAge) : p.getAge() >= fromAge && p.getAge() <= femaleToAge) - .collect(Collectors.toList()); + .toList(); } /** @@ -102,8 +101,8 @@ public List getCatsNames(List peopleList, int femaleAge) { public List validateCandidates(List candidates) { CandidateValidator validator = new CandidateValidator(); return candidates.stream() - .filter(c -> validator.test(c)) - .map(c -> c.getName()) + .filter(validator) + .map(Candidate::getName) .sorted() .toList(); }