Skip to content

modernise reflect.SliceHeader to unsafe.Slice#1400

Open
calmh wants to merge 1 commit into
mattn:masterfrom
calmh:unsafereflect
Open

modernise reflect.SliceHeader to unsafe.Slice#1400
calmh wants to merge 1 commit into
mattn:masterfrom
calmh:unsafereflect

Conversation

@calmh
Copy link
Copy Markdown
Contributor

@calmh calmh commented May 19, 2026

Avoid the unsafe use of reflect.StringHeader, using the same pattern already in place in bindText, and modernise deprecated reflect.SliceHeader usage to unsafe.Slice.

Signed-off-by: Jakob Borg <jakob@kastelo.net>
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 19, 2026

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.61%. Comparing base (18cdded) to head (fed9970).
⚠️ Report is 80 commits behind head on master.

Files with missing lines Patch % Lines
sqlite3_context.go 0.00% 4 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1400      +/-   ##
==========================================
+ Coverage   47.16%   51.61%   +4.45%     
==========================================
  Files          12       13       +1     
  Lines        1533     1856     +323     
==========================================
+ Hits          723      958     +235     
- Misses        669      739      +70     
- Partials      141      159      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants