From 21c20b8ce26a5637c93c8c5ee88438b74fa9d48f Mon Sep 17 00:00:00 2001 From: Maximilian Roos Date: Thu, 11 Jun 2026 10:54:44 -0700 Subject: [PATCH] docs(CLAUDE): codecov posts check runs on PR heads, not commit statuses A CI monitor polled the combined-status API (/commits//status) for codecov/patch and concluded codecov had stopped posting. Nothing was broken: codecov's GitHub App posts check runs on PR heads (statuses appear only on main pushes), and check runs never show up in the legacy status API. The check run also lands several minutes after the code-coverage job finishes (~9 min on #3035). State this in the Coverage section so merge gating polls gh pr checks rather than the status API. Co-Authored-By: Claude Fable 5 --- CLAUDE.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CLAUDE.md b/CLAUDE.md index 7c1dcfe5f4..64b8bc95a1 100644 --- a/CLAUDE.md +++ b/CLAUDE.md @@ -131,7 +131,7 @@ Why: wt installs a `signal_hook` SIGINT/SIGTERM handler so it can forward signal ## Coverage -**NEVER merge a PR with failing `codecov/patch` without explicit user approval.** It is marked "not required" in GitHub but still gates merge. On failure, investigate and fix the gap — write tests, or remove unused code (including specialized error handlers for rare cases where falling through to a general handler suffices). If you believe it's a false positive, ask the user before merging. Coverage runs include `--features shell-integration-tests` (CI `code-coverage` and local `task coverage`) — don't dismiss failures by claiming the feature is off. Investigation commands, rename false-positives, and the "N functions mismatched" warning: `tests/CLAUDE.md`. +**NEVER merge a PR with failing `codecov/patch` without explicit user approval.** It is marked "not required" in GitHub but still gates merge. On PR heads codecov posts **check runs** (codecov GitHub App), not commit statuses: poll with `gh pr checks ` or the check-runs API; the combined-status API (`/commits//status`) never shows them, and the check run lands a few minutes after the `code-coverage` job finishes. On failure, investigate and fix the gap — write tests, or remove unused code (including specialized error handlers for rare cases where falling through to a general handler suffices). If you believe it's a false positive, ask the user before merging. Coverage runs include `--features shell-integration-tests` (CI `code-coverage` and local `task coverage`) — don't dismiss failures by claiming the feature is off. Investigation commands, rename false-positives, and the "N functions mismatched" warning: `tests/CLAUDE.md`. ## Benchmarks & Traces