From 133516f65c64c199fafad229e2a259c9c6802e15 Mon Sep 17 00:00:00 2001
From: William Storey <wstorey@maxmind.com>
Date: Fri, 24 Apr 2026 10:27:26 -0700
Subject: [PATCH] Don't fail CI builds on NuGet audit advisories

Set WarningsNotAsErrors for NU1901-NU1904 when building in CI (CI=true).
This keeps TreatWarningsAsErrors strict locally so developers still
catch issues, but avoids every PR being blocked by a newly-published
advisory on a dependency until Dependabot can merge an upgrade. The
advisory still appears in the build output for visibility.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
---
 MaxMind.GeoIP2.Benchmark/MaxMind.GeoIP2.Benchmark.csproj | 4 ++++
 MaxMind.GeoIP2.UnitTests/MaxMind.GeoIP2.UnitTests.csproj | 4 ++++
 MaxMind.GeoIP2/MaxMind.GeoIP2.csproj                     | 4 ++++
 3 files changed, 12 insertions(+)

diff --git a/MaxMind.GeoIP2.Benchmark/MaxMind.GeoIP2.Benchmark.csproj b/MaxMind.GeoIP2.Benchmark/MaxMind.GeoIP2.Benchmark.csproj
index b6b78b9f..44aa4815 100644
--- a/MaxMind.GeoIP2.Benchmark/MaxMind.GeoIP2.Benchmark.csproj
+++ b/MaxMind.GeoIP2.Benchmark/MaxMind.GeoIP2.Benchmark.csproj
@@ -26,6 +26,10 @@
     <EnforceCodeStyleInBuild>true</EnforceCodeStyleInBuild>
     <EnableNETAnalyzers>true</EnableNETAnalyzers>
     <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
+    <!-- In CI, don't fail the build on NuGet audit advisories (NU1901-NU1905).
+         Advisories still appear in build output, and Dependabot handles the
+         actual fix. Local builds keep the strict behavior. -->
+    <WarningsNotAsErrors Condition="'$(CI)' == 'true'">$(WarningsNotAsErrors);NU1901;NU1902;NU1903;NU1904;NU1905</WarningsNotAsErrors>
   </PropertyGroup>
 
   <PropertyGroup Condition="'$(Configuration)|$(TargetFramework)|$(Platform)'=='Debug|net10.0|AnyCPU'">
diff --git a/MaxMind.GeoIP2.UnitTests/MaxMind.GeoIP2.UnitTests.csproj b/MaxMind.GeoIP2.UnitTests/MaxMind.GeoIP2.UnitTests.csproj
index 1b3c1e79..72291b4b 100644
--- a/MaxMind.GeoIP2.UnitTests/MaxMind.GeoIP2.UnitTests.csproj
+++ b/MaxMind.GeoIP2.UnitTests/MaxMind.GeoIP2.UnitTests.csproj
@@ -27,6 +27,10 @@
     <EnforceCodeStyleInBuild>true</EnforceCodeStyleInBuild>
     <EnableNETAnalyzers>true</EnableNETAnalyzers>
     <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
+    <!-- In CI, don't fail the build on NuGet audit advisories (NU1901-NU1905).
+         Advisories still appear in build output, and Dependabot handles the
+         actual fix. Local builds keep the strict behavior. -->
+    <WarningsNotAsErrors Condition="'$(CI)' == 'true'">$(WarningsNotAsErrors);NU1901;NU1902;NU1903;NU1904;NU1905</WarningsNotAsErrors>
     <UseMicrosoftTestingPlatformRunner>true</UseMicrosoftTestingPlatformRunner>
   </PropertyGroup>
 
diff --git a/MaxMind.GeoIP2/MaxMind.GeoIP2.csproj b/MaxMind.GeoIP2/MaxMind.GeoIP2.csproj
index f052dcb6..913b22b0 100644
--- a/MaxMind.GeoIP2/MaxMind.GeoIP2.csproj
+++ b/MaxMind.GeoIP2/MaxMind.GeoIP2.csproj
@@ -33,6 +33,10 @@
     <EnforceCodeStyleInBuild>true</EnforceCodeStyleInBuild>
     <EnableNETAnalyzers>true</EnableNETAnalyzers>
     <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
+    <!-- In CI, don't fail the build on NuGet audit advisories (NU1901-NU1905).
+         Advisories still appear in build output, and Dependabot handles the
+         actual fix. Local builds keep the strict behavior. -->
+    <WarningsNotAsErrors Condition="'$(CI)' == 'true'">$(WarningsNotAsErrors);NU1901;NU1902;NU1903;NU1904;NU1905</WarningsNotAsErrors>
   </PropertyGroup>
 
   <PropertyGroup Condition="'$(Configuration)|$(TargetFramework)|$(Platform)'=='Debug|net10.0|AnyCPU'">