Maxonrow Blockchain v1.0 - NFTs module contents enhancements

[githubckgoh1439]

Request Date/time : 27-May-2020

Details Request :

1. Item of MsgTypeSetNonFungibleTokenStatus : Request details info on Token Data Information

2. Item of MsgTypeSetNonFungibleItemStatus : Request details info on Item Details Information

3. Item of MsgTypeEndorsement : about the MEMO usage

4. Tab navigator : about the navigation of user experience

[githubckgoh1439]

Dear all,

Due to still under POC stage (work in progress) of the current documentation, please refer to :

https://github.com/githubckgoh1439/docs/tree/master

[githubckgoh1439]

@yk,

I already updated base on THREE items above. For the item-4, I still in progress and update later once completed.

Please review and comments.

[yk]

wrong user :)

[b00f]

@yk Please check them. It doesn't take time. You can check these commits:
githubckgoh1439@c4af455
githubckgoh1439@fa4dde4

[yk]

I'm not the person you meant to tag

[b00f]

@yk So sorry. That is bad of me. ;)

@yenkhoon Please take a look at @githubckgoh1439 commits.

[githubckgoh1439]

Hi, @yenkhoon

I changed a bit on the NFTs contents themes to suit the navigation features in the sidebar, as whole contents in one page.

U can check and comments later.

[yenkhoon]

hi goh, appreciate your good work. However there are few things could be tune to better.

The details,

remove the word behind all details and make it a title "Details"

status details -> Status
in this section you need to explain the available options(status) in one table. Or leave it as it is and make the status bold.

transferLimit details
need to add in the expectation input, we are expecting number string here. Also upon approved, it coundt be updated anymore.

mintLimit details
this need to explain we are expecting number string not other string. also need to add in the expectation input, we are expecting number string here. Also upon approved, it coundt be updated anymore.

burnable details
burnable flag is not update able after token has been approve also. this is wrong u mention freeze and unfreeze.

transferable details
please mention is not update able after approve.

modifiable details
we are talking about token but u mention item here. token has it own metadata as well. please correct it.

pub details
it is confusing to use signer here, can u please use minter instead? When pub flag set to true, anyone can mint the token item, but they can only mint to themselves.

if it is false, then the minter has to be the token owner.

tokenFees details
please mention this is compulsory upon approving token. And the token fees setting name can get from where? we have a link in core please link them.

endorserList details
For the public equals TRUE, system will do verification on the current signer whether come from the endorser list during Item Endorsement process. If not, with an alert of 'Invalid endorser'. Howevere if endorser list is set to empty, system will not do this validation during endorsement-item process. Prior to this, this endorser list will be set as one of the token flag components during approve-token.

this is wrong, endorserlist do not affect by the public flag.
Endorser list is there if the token approved and it has endorser list, then the token's item can be endorsed by the wallet which inside the endorser list only. And in this field we are expecting wallet address. If the endorser list is empty, then anyone can endorse.

[yenkhoon]

@githubckgoh1439

[githubckgoh1439]

Hi, YK Will follow up as above commented. TQ.

…

On Tue, Jun 2, 2020 at 9:00 AM yk ***@***.***> wrote: hi goh, appreciate your good work. However there are few things could be tune to better. The details, remove the word behind all details and make it a title "Details" *status details -> Status* in this section you need to explain the available options(status) in one table. Or leave it as it is and make the status bold. *transferLimit details* need to add in the expectation input, we are expecting number string here. Also upon approved, it coundt be updated anymore. *mintLimit details* this need to explain we are expecting number string not other string. also need to add in the expectation input, we are expecting number string here. Also upon approved, it coundt be updated anymore. *burnable details* burnable flag is not update able after token has been approve also. this is wrong u mention freeze and unfreeze. *transferable details* please mention is not update able after approve. *modifiable details* we are talking about token but u mention item here. token has it own metadata as well. please correct it. *pub details* it is confusing to use signer here, can u please use minter instead? When pub flag set to true, anyone can mint the token item, but they can only mint to themselves. if it is false, then the minter has to be the token owner. *tokenFees details* please mention this is compulsory upon approving token. And the token fees setting name can get from where? we have a link in core please link them. *endorserList details* For the public equals TRUE, system will do verification on the current signer whether come from the endorser list during Item Endorsement process. If not, with an alert of 'Invalid endorser'. Howevere if endorser list is set to empty, system will not do this validation during endorsement-item process. Prior to this, this endorser list will be set as one of the token flag components during approve-token. this is wrong, endorserlist do not affect by the public flag. Endorser list is there if the token approved and it has endorser list, then the token's item can be endorsed by the wallet which inside the endorser list only. And in this field we are expecting wallet address. If the endorser list is empty, then anyone can endorse. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AIQPD6ENHQVV2WGGYQTN3STRURFJVANCNFSM4NOSPRVA> .

[githubckgoh1439]

hi goh, appreciate your good work. However there are few things could be tune to better.

The details,

remove the word behind all details and make it a title "Details"

status details -> Status
in this section you need to explain the available options(status) in one table. Or leave it as it is and make the status bold.

transferLimit details
need to add in the expectation input, we are expecting number string here. Also upon approved, it coundt be updated anymore.

mintLimit details
this need to explain we are expecting number string not other string. also need to add in the expectation input, we are expecting number string here. Also upon approved, it coundt be updated anymore.

burnable details
burnable flag is not update able after token has been approve also. this is wrong u mention freeze and unfreeze.

transferable details
please mention is not update able after approve.

modifiable details
we are talking about token but u mention item here. token has it own metadata as well. please correct it.

pub details
it is confusing to use signer here, can u please use minter instead? When pub flag set to true, anyone can mint the token item, but they can only mint to themselves.

if it is false, then the minter has to be the token owner.

tokenFees details
please mention this is compulsory upon approving token. And the token fees setting name can get from where? we have a link in core please link them.

endorserList details
For the public equals TRUE, system will do verification on the current signer whether come from the endorser list during Item Endorsement process. If not, with an alert of 'Invalid endorser'. Howevere if endorser list is set to empty, system will not do this validation during endorsement-item process. Prior to this, this endorser list will be set as one of the token flag components during approve-token.

this is wrong, endorserlist do not affect by the public flag.
Endorser list is there if the token approved and it has endorser list, then the token's item can be endorsed by the wallet which inside the endorser list only. And in this field we are expecting wallet address. If the endorser list is empty, then anyone can endorse.

Goh question :

Item : modifiable details

I already double checked this. This modifiable only applied for the 'UpdateItemMetadata' & not for the 'UpdateNFTMetadata'.
So this not applicable to Token metadata updating. Am I Correct ? 

Item : tokenFees details

Is that link with this : 'GetTokenFeeSetting' in Fee Setting Module ?

[githubckgoh1439]

@yenkhoon

Please comments my question above.

[yenkhoon]

fee setting name in testnet
https://alloys-rpc.maxonrow.com/debug/fee_info?

yeap you are right.