Use the setting "customALGoFiles" from the custom template settings when updating #2227
OleWunschmann
started this conversation in
Ideas
Replies: 1 comment 1 reply
-
|
Go for it! |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Idea Description
If a custom AL-Go template contains files outside the default directories or uses non-standard file extensions, you can include them by setting
"customALGoFiles"."filesToInclude".The current problem: when you change that setting in the custom template, the first update workflow run does not pick up the new value. The first run only writes the template repo settings into
.github/AL-Go-TemplateRepoSettings.doNotEdit.json. Only on a second run does the workflow read that file and include the newfilesToIncludevalue. In practice this causes two CI/CD runs for a single change.Can the update workflow be adjusted to include the new template repository values during the same update run?
Proposed change:
Modify
Actions\CheckForUpdates\CheckForUpdates.ps1:$templateRepoSettingsobject into theGetFilesToUpdatefunction.Modify
Actions\CheckForUpdates\CheckForUpdates.HelperFunctions.ps1, functionGetFilesToUpdate:$settings, add"customALGoFiles"."filesToInclude"from the passed$templateRepoSettingsinto$filesToInclude."customALGoFiles"."filesToExclude"from$templateRepoSettingsinto$filesToExclude.Alternatively, instead of passing the entire
$templateRepoSettingsobject intoGetFilesToUpdate, we could pass only the custom include/exclude file lists to that function.This ensures the new custom file inclusion/exclusion values are considered immediately and prevents the need for a second CI/CD run.
Contribution (Optional)
Beta Was this translation helpful? Give feedback.
All reactions