[Change Request] codeunit 22 "Item Jnl.-Post Line", events OnInsertVarValueEntryOnBeforeInsertValueEntry, OnInsertTransferEntryOnBeforeInsertValueEntry, OnInsertCorrValueEntryOnBeforeInsert

[RytisLemezis]

Why do you need this change?

At 4PS Construct, we need access to the current Item Journal Line context in the before-insert value entry events that are raised during transfer, variance, and correction posting flows in codeunit 22 "Item Jnl.-Post Line".

In our extension scenarios, custom logic needs to inspect fields from ItemJnlLine such as document context, source information, job fields, dimension-related data, and entry-specific posting characteristics before deciding how to handle the value entry that is about to be inserted.

There are five events that are called before inserting value entry. The events OnItemValuePostingOnBeforeInsertValueEntry and OnInsertTransferEntryOnBeforeInsertValueEntry already exposes ItemJournalLine, but the OnInsertVarValueEntryOnBeforeInsertValueEntry, OnInsertTransferEntryOnBeforeInsertValueEntry, OnInsertCorrValueEntryOnBeforeInsert do not. These three events were added here #29649.

To support consistent and upgrade-safe extensibility, we need ItemJournalLine to be available on these before-insert value entry events as well.

Describe the request

On behalf of 4PS, I would like to request that ItemJournalLine is exposed on the before-insert value entry events in codeunit 22 "Item Jnl.-Post Line" so extensions can apply the same line-based logic across transfer, variance, and correction value entry scenarios.

Current integration events and suggested versions:

1. OnInsertVarValueEntryOnBeforeInsertValueEntry

Current version:

[IntegrationEvent(false, false)]
local procedure OnInsertVarValueEntryOnBeforeInsertValueEntry(var ValueEntry: Record "Value Entry"; var GlobalItemLedgerEntry: Record "Item Ledger Entry"; var IsHandled: Boolean)
begin
end;

Suggested version:

[IntegrationEvent(false, false)]
local procedure OnInsertVarValueEntryOnBeforeInsertValueEntry(var ValueEntry: Record "Value Entry"; var GlobalItemLedgerEntry: Record "Item Ledger Entry"; ItemJournalLine: Record "Item Journal Line"; var IsHandled: Boolean)
begin
end;

Relevant usage point:

ValueEntry."Cost per Unit" :=
  CalcCostPerUnit(ValueEntry."Cost Amount (Actual)", ValueEntry."Valued Quantity", false);
ValueEntry."Cost per Unit (ACY)" :=
  CalcCostPerUnit(ValueEntry."Cost Amount (Actual) (ACY)", ValueEntry."Valued Quantity", true);

IsHandled := false;
OnInsertVarValueEntryOnBeforeInsertValueEntry(ValueEntry, GlobalItemLedgEntry, ItemJnlLine, IsHandled);
if IsHandled then
    exit;

InsertValueEntry(ValueEntry, GlobalItemLedgEntry, false);

2. OnInsertTransferEntryOnBeforeInsertValueEntry

Current version:

[IntegrationEvent(false, false)]
local procedure OnInsertTransferEntryOnBeforeInsertValueEntry(var NewValueEntry: Record "Value Entry"; var NewItemLedgerEntry: Record "Item Ledger Entry"; ItemJournalLine: Record "Item Journal Line"; var ValueEntryNo: Integer; var IsHandled: Boolean)
begin
end;

Suggested version:

[IntegrationEvent(false, false)]
local procedure OnInsertTransferEntryOnBeforeInsertValueEntry(var NewValueEntry: Record "Value Entry"; var NewItemLedgerEntry: Record "Item Ledger Entry"; ItemJournalLine: Record "Item Journal Line"; var ValueEntryNo: Integer; var IsHandled: Boolean)
begin
end;

Relevant usage point:

ApplyItemLedgEntry(NewItemLedgEntry, ItemLedgEntry2, NewValueEntry, true);
AutoTrack(NewItemLedgEntry, IsReserved);

OnBeforeInsertTransferEntry(NewItemLedgEntry, OldItemLedgEntry, ItemJnlLine);

InsertItemLedgEntry(NewItemLedgEntry, true);

IsHandled := false;
OnInsertTransferEntryOnBeforeInsertValueEntry(NewValueEntry, NewItemLedgEntry, ItemJnlLine, ValueEntryNo, IsHandled);
if not IsHandled then begin
    InsertValueEntry(NewValueEntry, NewItemLedgEntry, true);
    UpdateUnitCost(NewValueEntry);
end;

xValueEntryNo := ValueEntryNo;
OnAfterInsertTransferEntry(ItemJnlLine, NewItemLedgEntry, OldItemLedgEntry, NewValueEntry, ValueEntryNo);
ValidateSequenceNo(ValueEntryNo, xValueEntryNo, Database::"Value Entry");
end;

3. OnInsertCorrValueEntryOnBeforeInsert

Current version:

[IntegrationEvent(false, false)]
local procedure OnInsertCorrValueEntryOnBeforeInsert(var NewValueEntry: Record "Value Entry"; var ItemLedgerEntry: Record "Item Ledger Entry"; var ShouldInsertValueEntry: Boolean)
begin
end;

Suggested version:

[IntegrationEvent(false, false)]
local procedure OnInsertCorrValueEntryOnBeforeInsert(var NewValueEntry: Record "Value Entry"; var ItemLedgerEntry: Record "Item Ledger Entry"; ItemJournalLine: Record "Item Journal Line"; var ShouldInsertValueEntry: Boolean)
begin
end;

Relevant usage point:

PostInventoryToGL(NewValueEntry);

InsertItemReg(0, 0, NewValueEntry."Entry No.", 0);
NewValueEntry."Item Register No." := ItemReg."No.";

ShouldInsertValueEntry := true;
OnInsertCorrValueEntryOnBeforeInsert(NewValueEntry, ItemLedgEntry, ItemJnlLine, ShouldInsertValueEntry);
if not ShouldInsertValueEntry then
    exit;

NewValueEntry.Insert(true);

xValueEntryNo := ValueEntryNo;
OnAfterInsertCorrValueEntry(NewValueEntry, ItemJnlLine, ItemLedgEntry, ValueEntryNo);
ValidateSequenceNo(ValueEntryNo, xValueEntryNo, Database::"Value Entry");

ItemApplnEntry.SetOutboundsNotUpdated(ItemLedgEntry);

UpdateAdjmtProperties(NewValueEntry, ItemLedgEntry."Posting Date");

InsertPostValueEntryToGL(NewValueEntry);

Internal work item: AB#639952

[github-actions]

Hi @RytisLemezis,

Thank you for your extensibility request. To help us process it efficiently, please update the issue to include the required information.

📚 Extensibility Guidelines

Missing Information:

• Correction-flow clarification: Codeunit 22 already has OnBeforeInsertCorrValueEntry earlier in the same procedure, and it exposes NewValueEntry, ItemJournalLine, ItemLedgerEntry, and ValueEntryNo. Please clarify why the later OnInsertCorrValueEntryOnBeforeInsert timing is specifically required instead of using the existing event.

Please update the issue with the missing details. We'll automatically re-analyze once updated.

Note

Automatically generated by the Triage Agent — advisory only. An engineer will review before any action is taken.

Tip

Not accurate? Reply with /not-accurate (optional: add a short explanation). Your feedback improves future responses.

[RytisLemezis]

The existing OnBeforeInsertCorrValueEntry event is not sufficient for this scenario because it does not have ShouldInsertValueEntry and by subscribing to it there is no way to avoid NewValueEntry.Insert(true);

[github-actions]

✅ Analysis complete - ready for further processing

---

Implementation:

Expose ItemJournalLine on the before-insert value entry events used in transfer, variance, and correction posting flows in codeunit 22 Item Jnl.-Post Line.

Location in InsertTransferEntry(), InsertVarValueEntry(), and InsertCorrValueEntry() procedures:

        OnBeforeInsertTransferEntry(NewItemLedgEntry, OldItemLedgEntry, ItemJnlLine);

        InsertItemLedgEntry(NewItemLedgEntry, true);

        IsHandled := false;
        OnInsertTransferEntryOnBeforeInsertValueEntry(NewValueEntry, NewItemLedgEntry, ValueEntryNo, IsHandled, ItemJnlLine);
        if not IsHandled then begin
            InsertValueEntry(NewValueEntry, NewItemLedgEntry, true);
            UpdateUnitCost(NewValueEntry);
        end;

        xValueEntryNo := ValueEntryNo;

        ValueEntry."Cost per Unit" :=
          CalcCostPerUnit(ValueEntry."Cost Amount (Actual)", ValueEntry."Valued Quantity", false);
        ValueEntry."Cost per Unit (ACY)" :=
          CalcCostPerUnit(ValueEntry."Cost Amount (Actual) (ACY)", ValueEntry."Valued Quantity", true);

        IsHandled := false;
        OnInsertVarValueEntryOnBeforeInsertValueEntry(ValueEntry, GlobalItemLedgEntry, IsHandled, ItemJnlLine);
        if IsHandled then
            exit;

        InsertValueEntry(ValueEntry, GlobalItemLedgEntry, false);

        InsertItemReg(0, 0, NewValueEntry."Entry No.", 0);
        NewValueEntry."Item Register No." := ItemReg."No.";

        ShouldInsertValueEntry := true;
        OnInsertCorrValueEntryOnBeforeInsert(NewValueEntry, ItemLedgEntry, ShouldInsertValueEntry, ItemJnlLine);
        if not ShouldInsertValueEntry then
            exit;

        NewValueEntry.Insert(true);

        xValueEntryNo := ValueEntryNo;

Event Publisher (add at the end of the codeunit with other events):

    [IntegrationEvent(false, false)]
    local procedure OnInsertVarValueEntryOnBeforeInsertValueEntry(var ValueEntry: Record "Value Entry"; var GlobalItemLedgerEntry: Record "Item Ledger Entry"; var IsHandled: Boolean; ItemJournalLine: Record "Item Journal Line")
    begin
    end;

    [IntegrationEvent(false, false)]
    local procedure OnInsertTransferEntryOnBeforeInsertValueEntry(var NewValueEntry: Record "Value Entry"; var NewItemLedgerEntry: Record "Item Ledger Entry"; var ValueEntryNo: Integer; var IsHandled: Boolean; ItemJournalLine: Record "Item Journal Line")
    begin
    end;

    [IntegrationEvent(false, false)]
    local procedure OnInsertCorrValueEntryOnBeforeInsert(var NewValueEntry: Record "Value Entry"; var ItemLedgerEntry: Record "Item Ledger Entry"; var ShouldInsertValueEntry: Boolean; ItemJournalLine: Record "Item Journal Line")
    begin
    end;

---

File: ItemJnlPostLine.Codeunit.al

Note

Automatically generated by the Triage Agent — advisory only. An engineer will review before any action is taken.

Tip

Not accurate? Reply with /not-accurate (optional: add a short explanation). Your feedback improves future responses.