Debug Failure. Did not expect JsxExpression to have an Identifier in its trivia

[cevek]

TypeScript Version: 2.9.2
Can't use ts@next because of #25484 that happens every 5min

Search Terms:

Code

Error: Debug Failure. Did not expect JsxExpression to have an Identifier in its trivia
    at addSyntheticNodes (/usr/local/lib/node_modules/typescript/lib/tsserver.js:89462:30)
    at createChildren (/usr/local/lib/node_modules/typescript/lib/tsserver.js:89451:9)
    at NodeObject.getChildren (/usr/local/lib/node_modules/typescript/lib/tsserver.js:89400:56)
    at getTokenAtPositionWorker (/usr/local/lib/node_modules/typescript/lib/tsserver.js:71215:43)
    at Object.getTokenAtPosition (/usr/local/lib/node_modules/typescript/lib/tsserver.js:71206:16)
    at getInfo (/usr/local/lib/node_modules/typescript/lib/tsserver.js:85133:28)
    at Object.getCodeActions (/usr/local/lib/node_modules/typescript/lib/tsserver.js:85095:28)
    at /usr/local/lib/node_modules/typescript/lib/tsserver.js:83738:121
    at Object.flatMap (/usr/local/lib/node_modules/typescript/lib/tsserver.js:1802:25)
    at Object.getFixes (/usr/local/lib/node_modules/typescript/lib/tsserver.js:83738:23)
    at /usr/local/lib/node_modules/typescript/lib/tsserver.js:90750:35
    at Object.flatMap (/usr/local/lib/node_modules/typescript/lib/tsserver.js:1802:25)
    at Object.getCodeFixesAtPosition (/usr/local/lib/node_modules/typescript/lib/tsserver.js:90748:23)
    at IOSession.Session.getCodeFixes (/usr/local/lib/node_modules/typescript/lib/tsserver.js:97423:64)
    at Session.handlers.ts.createMapFromTemplate._a.(anonymous function) (/usr/local/lib/node_modules/typescript/lib/tsserver.js:96250:61)
    at /usr/local/lib/node_modules/typescript/lib/tsserver.js:97580:88
    at IOSession.Session.executeWithRequestId (/usr/local/lib/node_modules/typescript/lib/tsserver.js:97571:28)
    at IOSession.Session.executeCommand (/usr/local/lib/node_modules/typescript/lib/tsserver.js:97580:33)
    at IOSession.Session.onMessage (/usr/local/lib/node_modules/typescript/lib/tsserver.js:97600:35)
    at Interface.<anonymous> (/usr/local/lib/node_modules/typescript/lib/tsserver.js:98831:27)
    at emitOne (events.js:96:13)
    at Interface.emit (events.js:191:7)
    at Interface._onLine (readline.js:241:10)
    at Interface._normalWrite (readline.js:384:12)
    at Socket.ondata (readline.js:101:10)
    at emitOne (events.js:96:13)
    at Socket.emit (events.js:191:7)
    at readableAddChunk (_stream_readable.js:178:18)
    at Socket.Readable.push (_stream_readable.js:136:10)
    at Pipe.onread (net.js:560:20)

Expected behavior:

Actual behavior:

Playground Link:

Related Issues:

tsserver logs id: 1660483066

@cevek Do you have any example code I can use to reproduce the issue?

[cevek]

@Andy-MS I don't know how to reproduce this error

@cevek The error happens because some JsxExpression (as in {0} in <Foo attr={0} />) parsed funny and we found an Identifier where one shouldn't exist. The tsserver log (you gave an ID but I don't know how to use that?) might give some indication of the file being scanned. You could also modify the Debug.fail statement in addSyntheticNodes to Debug.fail("For the repro: " + parent.getText()); that should show you the particular one it was failing on.

[cevek]

The tsserver log (you gave an ID but I don't know how to use that?)

I think you should ask about it @mhegazy

@cevek It looks like the error is happening somewhere around <form onSubmit={onSubmit} in Registration.tsx when you were editing it. The error is then triggered when the editor asks for refactors at a certain position. It shouldn't have anything to do with types, just with the text in the file not parsing right and being detected during the call to node.getChildren() in getTokenAtPosition. Next time you see this error, could you take a snapshot of the current file?

[cevek]

Also I have a lot of similar error(ts@3.1.0-dev.20180717):

Error: Debug Failure. Did not expect JsxSelfClosingElement to have an Identifier in its trivia
    at addSyntheticNodes (/usr/local/lib/node_modules/typescript/lib/tsserver.js:110415:30)
    at createChildren (/usr/local/lib/node_modules/typescript/lib/tsserver.js:110404:9)
    at NodeObject.getChildren (/usr/local/lib/node_modules/typescript/lib/tsserver.js:110348:56)
    at getTokenAtPositionWorker (/usr/local/lib/node_modules/typescript/lib/tsserver.js:88795:43)
    at getTokenAtPosition (/usr/local/lib/node_modules/typescript/lib/tsserver.js:88787:16)
    at Object.findTokenOnLeftOfPosition (/usr/local/lib/node_modules/typescript/lib/tsserver.js:88828:31)
    at Object.getSignatureHelpItems (/usr/local/lib/node_modules/typescript/lib/tsserver.js:98753:36)
    at Object.getSignatureHelpItems (/usr/local/lib/node_modules/typescript/lib/tsserver.js:111549:37)
    at IOSession.Session.getSignatureHelpItems (/usr/local/lib/node_modules/typescript/lib/tsserver.js:119021:62)
    at Session.handlers.ts.createMapFromTemplate._a.(anonymous function) (/usr/local/lib/node_modules/typescript/lib/tsserver.js:118049:61)
    at /usr/local/lib/node_modules/typescript/lib/tsserver.js:119442:88
    at IOSession.Session.executeWithRequestId (/usr/local/lib/node_modules/typescript/lib/tsserver.js:119433:28)
    at IOSession.Session.executeCommand (/usr/local/lib/node_modules/typescript/lib/tsserver.js:119442:33)
    at IOSession.Session.onMessage (/usr/local/lib/node_modules/typescript/lib/tsserver.js:119462:35)
    at Interface.<anonymous> (/usr/local/lib/node_modules/typescript/lib/tsserver.js:120735:27)

[ChuckJonas]

is there someway to recover from this error (tried restarting ts service)? When this happens, the only way I can seemly fix it is to reload vscode... This is especially a pain because I am typically using integrated terminals for my dev server and have to restart them