Skip to content

Add a step to verify the JS emitted by the tests is valid #2818

@Arnavion

Description

@Arnavion

... to prevent tests with broken emit getting checked in, like the original one in 55af7b3#diff-5a553969b7d75b3baab89d60e61bcd5b.

Running the output will require too much effort in the test as well as setting up the environment, so I think only parsing is feasible. It'd require a parser that understands ES6, or perhaps the TS parser itself (with the risk of not noticing bugs that also affect the parser.)

It would also require some way of marking tests as "expected to emit valid JS regardless of type errors", since the presence of a .errors.txt doesn't indicate whether the errors are of syntax or type.

Metadata

Metadata

Assignees

Labels

InfrastructureIssue relates to TypeScript team infrastructure

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions