completions don't include primitives for type arguments inside a function

[ChuckJonas]

• VSCode Version: 1.29.1 (1.29.1)
• OS Version: OSX 10.12.6

Steps to Reproduce:

1. create a node typescript project
2. npm install querystring
3. type let m = new Map<string,

Expected:
I would have a Map with string key. No autocomplete would be preformed since I already have a valid statement

Result:
When you type the , vscode will autocomplete to let spMap = new Map<stringify, and add an import for import { stringify } from 'querystring';.

I haven't tested this with other primitive types, so I only know for sure that it fails with string.

Does this issue occur when all extensions are disabled?: Yes

[mjbvz]

I can't repo this. What suggestion are shown when you type out string? Is stringify selected?

[ChuckJonas]

@mjbvz yes...

The same thing happens when I try let map = new Map<number,. It gets autocompleted to let map = new Map<Number, which is the top suggestion and obviously not what I mean.

Is there someway to disable the autocomplete committing on ,? It's incredible how a small issue like this can disrupt your train of thought.

[ChuckJonas]

Ok... I narrowed it down and reproduced it in the insiders build. It only seems to break when passing a generic param inside a function.

Same thing with a with a custom generic interface:

This was done without a project open (new window -> new file), but you can see it's auto-completing to String instead of string.

[mjbvz]

Confirmed that string is not returned inside a function with TS 3.3.0-dev.20181129

@ChuckJonas Set "editor.acceptSuggestionOnCommitCharacter": false to disable commit on , in VS Code

[ChuckJonas]

@mjbvz so... this will be tagged as a bug? Setting "editor.acceptSuggestionOnCommitCharacter": false is less than ideal because now I also won't get completions on . or ;