You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Math.sign's documentation comment is grammatically incorrect.
/** * Returns the sign of the x, indicating whether x is positive, negative or zero. * @param x The numeric expression to test */sign(x: number): number;
"The sign of the x" is both poor English and inconsistent with other functions in the exact same file (log1p and expm1 both correctly use "...of x" just 30 or so lines down!).
Note
I know this is an incredibly minor and arguably nitpicky bug report, but its small scope renders it all the easier to fix.
⚙ Compilation target
ES2015 or higher
⚙ Library
lib.es2015.core.d.tsMissing / Incorrect Definition
Math.sign's documentation comment is grammatically incorrect."The sign of the x" is both poor English and inconsistent with other functions in the exact same file (
log1pandexpm1both correctly use "...of x" just 30 or so lines down!).Note
I know this is an incredibly minor and arguably nitpicky bug report, but its small scope renders it all the easier to fix.
Sample Code
https://www.typescriptlang.org/play/?#code/LIQwLgFgdAzglgcwHZA
Documentation Link
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Math/sign