From 723ee8a35e6bc7ea7791ce03cfb19f3300043a1b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E7=8E=8B=E6=96=87=E7=92=90?= Date: Thu, 2 Aug 2018 18:33:15 +0800 Subject: [PATCH 1/3] visit exclamation token --- src/compiler/visitor.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/visitor.ts b/src/compiler/visitor.ts index 2cfb469f15296..9a7c1c41cfdb0 100644 --- a/src/compiler/visitor.ts +++ b/src/compiler/visitor.ts @@ -268,7 +268,7 @@ namespace ts { nodesVisitor((node).decorators, visitor, isDecorator), nodesVisitor((node).modifiers, visitor, isModifier), visitNode((node).name, visitor, isPropertyName), - visitNode((node).questionToken, tokenVisitor, isToken), + (visitNode((node).questionToken, tokenVisitor, isToken), visitNode((node).exclamationToken, tokenVisitor, isToken)), visitNode((node).type, visitor, isTypeNode), visitNode((node).initializer, visitor, isExpression)); From 22672f33877b2170c2b2f6edb806ce16d57f66d1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E7=8E=8B=E6=96=87=E7=92=90?= Date: Fri, 7 Sep 2018 11:45:32 +0800 Subject: [PATCH 2/3] add comment --- src/compiler/visitor.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/src/compiler/visitor.ts b/src/compiler/visitor.ts index 9a7c1c41cfdb0..5fc0b0ccc711c 100644 --- a/src/compiler/visitor.ts +++ b/src/compiler/visitor.ts @@ -268,6 +268,7 @@ namespace ts { nodesVisitor((node).decorators, visitor, isDecorator), nodesVisitor((node).modifiers, visitor, isModifier), visitNode((node).name, visitor, isPropertyName), + // QuestionToken and ExclamationToken is uniqued in Property Declaration and the signature of 'updateProperty' is that too (visitNode((node).questionToken, tokenVisitor, isToken), visitNode((node).exclamationToken, tokenVisitor, isToken)), visitNode((node).type, visitor, isTypeNode), visitNode((node).initializer, visitor, isExpression)); From 6e0b39e39976a59d9df2bfceffbb90ec76032707 Mon Sep 17 00:00:00 2001 From: Ron Buckton Date: Tue, 23 Apr 2019 21:27:06 -0500 Subject: [PATCH 3/3] Update src/compiler/visitor.ts Co-Authored-By: Kingwl --- src/compiler/visitor.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/visitor.ts b/src/compiler/visitor.ts index 16880972b69c7..c5cb3f87fc50d 100644 --- a/src/compiler/visitor.ts +++ b/src/compiler/visitor.ts @@ -269,7 +269,7 @@ namespace ts { nodesVisitor((node).modifiers, visitor, isModifier), visitNode((node).name, visitor, isPropertyName), // QuestionToken and ExclamationToken is uniqued in Property Declaration and the signature of 'updateProperty' is that too - (visitNode((node).questionToken, tokenVisitor, isToken), visitNode((node).exclamationToken, tokenVisitor, isToken)), + visitNode((node).questionToken || (node).exclamationToken, tokenVisitor, isToken), visitNode((node).type, visitor, isTypeNode), visitNode((node).initializer, visitor, isExpression));