From 8e84ec769fee20bfcc8e940ae6ad60a32482c6c7 Mon Sep 17 00:00:00 2001 From: TrellixVulnTeam Date: Sun, 2 Oct 2022 01:57:16 +0000 Subject: [PATCH 1/2] Adding tarfile member sanitization to extractall() --- modules/until_config.py | 21 ++++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/modules/until_config.py b/modules/until_config.py index 596c157..12b39d1 100644 --- a/modules/until_config.py +++ b/modules/until_config.py @@ -75,7 +75,26 @@ def get_config(cls, pretrained_model_name, cache_dir, type_vocab_size, state_dic logger.info("extracting archive file {} to temp dir {}".format( resolved_archive_file, tempdir)) with tarfile.open(resolved_archive_file, 'r:gz') as archive: - archive.extractall(tempdir) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner) + + + safe_extract(archive, tempdir) serialization_dir = tempdir # Load config config_file = os.path.join(serialization_dir, cls.config_name) From eac6d4e1acaa8dbd40d7a80c77ab50d000152945 Mon Sep 17 00:00:00 2001 From: TrellixVulnTeam Date: Tue, 4 Oct 2022 14:50:15 +0000 Subject: [PATCH 2/2] Adding numeric_owner as keyword arguement --- modules/until_config.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/until_config.py b/modules/until_config.py index 12b39d1..165bb2f 100644 --- a/modules/until_config.py +++ b/modules/until_config.py @@ -91,7 +91,7 @@ def safe_extract(tar, path=".", members=None, *, numeric_owner=False): if not is_within_directory(path, member_path): raise Exception("Attempted Path Traversal in Tar File") - tar.extractall(path, members, numeric_owner) + tar.extractall(path, members, numeric_owner=numeric_owner) safe_extract(archive, tempdir)